Check for undefined peekCommand queue entry #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26
Problem
In some cases, bad commands (e.g. invalid keys) sent in parallel at a high throughput to a memcache server will result in the error described in #26.
Since this code path runs in an event listener after client initialization and not as a result of a function called in user land, this results in a crashed Node.js process (aka uncaught exception).
Solution
Check
retrievefor truthiness before attempting to push a value on it or set.erroron it.This doesn't solve the underlying root/concurrency problem per-se, but it makes the method more resilient to upstream failure.