Feature: Midi - make it possible to handle 'SystemRealTime' events synchronously#643
Conversation
|
@HeckHeckHeckHeck with your digging into midi clock, do you have any thoughts on this issue? |
|
its just a "back of the envelope" design suggestion prototype. Works for me (perfectly actually). |
|
+1 on this -- I've been ripping my hair out why my Seed inexplicably thought my MIDI channel was switching to 9 spontaneously. I just wrote my own fix at master...TomFrost:libDaisy:fix/midi-parser-running-status to detect the RTClock message before the parser resets. I should have looked here first. IMO @HeckHeckHeckHeck 's solution is more elegant, but I'll keep mine here for reference if it's worthwhile to anyone. |
|
This looks like a solid starting point for improvements with realtime handling to me! I'll be looking at this and the new related (running status fix) PR early next week. Thanks for the contribution! |
|
I merged the more passive realtime-related PR first so that I could test this on top of it, and make sure everything seemed to be consistent (mostly since this is opt-in, and that one may resolve some issues people were running into). Just finished testing this out a bit and comparing between the two modes, and everything seems to work great in the few cases I tested it. I didn't make any practical programs that would take advantage of the improvement yet (though I do have a few projects that I think could benefit from this update). Thanks again for the contribution, @HeckHeckHeckHeck! @TomFrost It looks like the changes in #643 implement the fix that you had staged. So everything should be pretty solid in the System Realtime now. |
|
cool, thanks. appreciated. And yeah i went for min code change philosophy here to clearly communicate intent basically, so no design beauty, but, been using it since more than a year now in many little programs, always worked reliably, even on stage ;) |
Sync more precisely to a Midi clock signal.