-
Notifications
You must be signed in to change notification settings - Fork 174
Add the "no data" option for the Metric Threshold rule #4967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 GitHub commentsJust comment with:
|
|
@benakansara Thanks for your feedback! |
benakansara
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| [[if-there-is-no-data]] | ||
| == If there is no data | ||
|
|
||
| In the **If there is no data**, you can control how alerts behave when data stops being reported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the word panel or dialog missing here? For example:
In the If there is no data panel, you can control...
Or maybe section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about the same while editing...it's not a dialog, might be a panel, it's an area of the window. We can check with UX how this is called.
bmorelli25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions, then LGTM
This PR updates the Create a metric threshold rule page with the notion of "No Data" when creating metric threshold alerts.
Related issue
Closes elastic/docs-content#4664
Checklist
Follow-up tasks
Select one.