Change page_size and batch_size manifest variable type from text to integer - part 1#19249
Draft
kcreddy wants to merge 1 commit into
Draft
Change page_size and batch_size manifest variable type from text to integer - part 1#19249kcreddy wants to merge 1 commit into
kcreddy wants to merge 1 commit into
Conversation
…nteger - part 1 Several integrations declare page_size or batch_size manifest variables with type: text when the value is always a positive integer. Fleet performs no numeric validation on text fields, so a user can set these to arbitrary strings. Changing to type: integer ensures Fleet rejects non-numeric input. Relates elastic#19248 [git-generate] for pkg in abnormal_security armis authentik aws_securityhub cyberark_epm; do find "packages/$pkg/" -type f -name manifest.yml \ -exec perl -i -0pe 's/(name: (?:page_size|batch_size)\n\s+)type: text/$1type: integer/g' {} + done for pkg in $(git diff --name-only packages/ | cut -d/ -f1,2 | sort -u); do ( cd "$pkg" elastic-package changelog add \ --description "Change page_size/batch_size variable type from text to integer for Fleet input validation." \ --type bugfix --next patch \ --link "elastic#19249" ) done
ab0222a to
044a9da
Compare
💚 Build Succeeded
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.How to test this PR locally
Related issues
type: text#19248