Skip to content

Change page_size and batch_size manifest variable type from text to integer - part 1#19249

Draft
kcreddy wants to merge 1 commit into
elastic:mainfrom
kcreddy:fix-batch-page-sizes-type-1
Draft

Change page_size and batch_size manifest variable type from text to integer - part 1#19249
kcreddy wants to merge 1 commit into
elastic:mainfrom
kcreddy:fix-batch-page-sizes-type-1

Conversation

@kcreddy
Copy link
Copy Markdown
Contributor

@kcreddy kcreddy commented May 27, 2026

Proposed commit message

Change page_size and batch_size manifest variable type from text to integer - part 1

Several integrations declare page_size or batch_size manifest variables
with type: text when the value is always a positive integer. Fleet
performs no numeric validation on text fields, so a user can set these
to arbitrary strings. Changing to type: integer ensures Fleet rejects
non-numeric input.

Relates https://github.com/elastic/integrations/issues/19248

[git-generate]
for pkg in abnormal_security armis authentik aws_securityhub cyberark_epm; do
  find "packages/$pkg/" -type f -name manifest.yml \
    -exec perl -i -0pe 's/(name: (?:page_size|batch_size)\n\s+)type: text/$1type: integer/g' {} +
done
for pkg in $(git diff --name-only packages/ | cut -d/ -f1,2 | sort -u); do
  (
    cd "$pkg"
    elastic-package changelog add \
      --description "Change page_size/batch_size variable type from text to integer for Fleet input validation." \
      --type bugfix --next patch \
      --link "https://github.com/elastic/integrations/pull/19249"
  )
done

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

Related issues

…nteger - part 1

Several integrations declare page_size or batch_size manifest variables
with type: text when the value is always a positive integer. Fleet
performs no numeric validation on text fields, so a user can set these
to arbitrary strings. Changing to type: integer ensures Fleet rejects
non-numeric input.

Relates elastic#19248

[git-generate]
for pkg in abnormal_security armis authentik aws_securityhub cyberark_epm; do
  find "packages/$pkg/" -type f -name manifest.yml \
    -exec perl -i -0pe 's/(name: (?:page_size|batch_size)\n\s+)type: text/$1type: integer/g' {} +
done
for pkg in $(git diff --name-only packages/ | cut -d/ -f1,2 | sort -u); do
  (
    cd "$pkg"
    elastic-package changelog add \
      --description "Change page_size/batch_size variable type from text to integer for Fleet input validation." \
      --type bugfix --next patch \
      --link "elastic#19249"
  )
done
@kcreddy kcreddy force-pushed the fix-batch-page-sizes-type-1 branch from ab0222a to 044a9da Compare May 27, 2026 21:09
@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants