[cloudflare_logpush] Ingest Pipeline Improvments#19234
[cloudflare_logpush] Ingest Pipeline Improvments#19234brijesh-elastic wants to merge 10 commits into
Conversation
…tiple data streams (elastic#18685) Enhancements: - Bump ECS version to `git@v9.3.0` and `format_version` to `3.3.2`. - Replace deprecated `agent.yml` with `beats.yml` and use `external: ecs` in `base-fields.yml` across all 21 data streams. - Add new fields with corresponding ingest pipeline processors: - `device_posture` (RegistrationID) - `firewall_event` (FraudUserID) - `gateway_dns` (12 fields including InternalDNS*, QueryApplication*, RequestContext*) - `gateway_http` (AppControlInfo, ApplicationStatuses, RedirectTargetURI, RegistrationID) - `gateway_network` (RegistrationID) - `http_request` (11 fields including Fraud*, WebAssets*, WorkerScriptName) - `network_analytics` (DNSQueryName, DNSQueryType, PFPCustomTag) - `network_session` (InitialOriginIP, RegistrationID, ResolvedFQDN, SNI) - `workers_trace` (CPUTimeMs, WallTimeMs)
…d use of dissect processors (elastic#18952) - Replace `rename` with typed `convert` processors for `ip`, `long`, and `boolean` fields. This validates values against `fields.yml` mappings and prevents off-type indexing. - Replace `grok` with `dissect` for simple delimiter-based patterns.
Run `elastic-package modify -m pipeline-tag` to add a tag key to each processor.
…latest null-removal script (elastic#19003) - Standardize the `error.message` format and implement the latest null-removal script; additionally, add `on_failure` handlers to all script processors. - Remove `ignore_failure: true` from JSON processors and append processors for `related.*` fields. - Utilize custom fields instead of standard ECS fields within the `related.*` append processors to improve maintainability and consistency. - Apply `ignore_empty_value: true` and `ignore_missing: true` across processors, and refine `if` conditions to ensure the ingest pipeline is fully null-safe.
…streams (elastic#19085) Factor the string-to-number conversion out of each data stream's Painless timestamp script into a preceding convert processor. This leaves the script responsible only for magnitude adjustment (nanoseconds to milliseconds or seconds to milliseconds) and lets it assume its input is already numeric. The previous script performed type checking, string parsing, and magnitude adjustment in a single try/catch block that silently swallowed all exceptions. With the conversion handled by a separate processor, the script's on_failure handler now surfaces errors properly via error.message.
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Vale Linting ResultsSummary: 136 warnings, 7 suggestions found
|
| File | Line | Rule | Message |
|---|---|---|---|
| packages/cloudflare_logpush/docs/README.md | 79 | Elastic.DirectionalLanguage | Don't use directional language. Use 'in the following section' instead of 'listed below'. |
| packages/cloudflare_logpush/docs/README.md | 105 | Elastic.DirectionalLanguage | Don't use directional language. Use 'the following element' instead of 'the steps below'. |
| packages/cloudflare_logpush/docs/README.md | 108 | Elastic.DontUse | Don't use 'please'. |
| packages/cloudflare_logpush/docs/README.md | 112 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 131 | Elastic.DontUse | Don't use 'just'. |
| packages/cloudflare_logpush/docs/README.md | 151 | Elastic.DontUse | Don't use 'Please'. |
| packages/cloudflare_logpush/docs/README.md | 152 | Elastic.DontUse | Don't use 'please'. |
| packages/cloudflare_logpush/docs/README.md | 348 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/cloudflare_logpush/docs/README.md | 348 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 349 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 350 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/cloudflare_logpush/docs/README.md | 351 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 352 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 501 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/cloudflare_logpush/docs/README.md | 501 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 502 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 503 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/cloudflare_logpush/docs/README.md | 504 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 505 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 674 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/cloudflare_logpush/docs/README.md | 674 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 675 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 676 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/cloudflare_logpush/docs/README.md | 677 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 678 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 854 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/cloudflare_logpush/docs/README.md | 854 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 855 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 856 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/cloudflare_logpush/docs/README.md | 857 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 858 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 959 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'that is' instead of 'i.e'. |
| packages/cloudflare_logpush/docs/README.md | 961 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/cloudflare_logpush/docs/README.md | 961 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 962 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 963 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/cloudflare_logpush/docs/README.md | 964 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 965 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 1092 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/cloudflare_logpush/docs/README.md | 1092 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 1093 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 1094 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/cloudflare_logpush/docs/README.md | 1095 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 1096 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 1273 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/cloudflare_logpush/docs/README.md | 1273 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 1274 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 1275 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/cloudflare_logpush/docs/README.md | 1276 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 1277 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 1535 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/cloudflare_logpush/docs/README.md | 1535 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 1536 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 1537 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/cloudflare_logpush/docs/README.md | 1538 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 1539 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 1767 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/cloudflare_logpush/docs/README.md | 1767 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 1768 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 1769 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/cloudflare_logpush/docs/README.md | 1770 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 1771 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 2110 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/cloudflare_logpush/docs/README.md | 2110 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 2111 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 2112 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/cloudflare_logpush/docs/README.md | 2113 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 2114 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 2366 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'eg'. |
| packages/cloudflare_logpush/docs/README.md | 2411 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/cloudflare_logpush/docs/README.md | 2411 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 2412 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 2413 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/cloudflare_logpush/docs/README.md | 2414 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 2415 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 2636 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/cloudflare_logpush/docs/README.md | 2636 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 2637 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 2638 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/cloudflare_logpush/docs/README.md | 2639 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 2640 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 3093 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/cloudflare_logpush/docs/README.md | 3093 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 3094 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 3095 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/cloudflare_logpush/docs/README.md | 3096 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 3097 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 3260 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/cloudflare_logpush/docs/README.md | 3260 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 3261 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 3262 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/cloudflare_logpush/docs/README.md | 3263 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 3264 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 3385 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/cloudflare_logpush/docs/README.md | 3385 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 3386 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 3387 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/cloudflare_logpush/docs/README.md | 3388 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 3389 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 3747 | Elastic.BritishSpellings | Use American English spelling 'acknowledgment' instead of British English 'Acknowledgement'. |
| packages/cloudflare_logpush/docs/README.md | 3766 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/cloudflare_logpush/docs/README.md | 3766 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 3767 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 3768 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/cloudflare_logpush/docs/README.md | 3769 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 3770 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 4052 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/cloudflare_logpush/docs/README.md | 4052 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 4053 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 4054 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/cloudflare_logpush/docs/README.md | 4055 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 4056 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 4177 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/cloudflare_logpush/docs/README.md | 4177 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 4178 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 4179 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/cloudflare_logpush/docs/README.md | 4180 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 4181 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 4389 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/cloudflare_logpush/docs/README.md | 4389 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 4390 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 4391 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/cloudflare_logpush/docs/README.md | 4392 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 4393 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 4602 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/cloudflare_logpush/docs/README.md | 4602 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 4603 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 4604 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/cloudflare_logpush/docs/README.md | 4605 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 4606 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 4755 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/cloudflare_logpush/docs/README.md | 4755 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 4756 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/cloudflare_logpush/docs/README.md | 4757 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/cloudflare_logpush/docs/README.md | 4758 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/cloudflare_logpush/docs/README.md | 4759 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
💡 Suggestions (7)
| File | Line | Rule | Message |
|---|---|---|---|
| packages/cloudflare_logpush/docs/README.md | 5 | Elastic.Semicolons | Use semicolons judiciously. |
| packages/cloudflare_logpush/docs/README.md | 5 | Elastic.Semicolons | Use semicolons judiciously. |
| packages/cloudflare_logpush/docs/README.md | 5 | Elastic.Semicolons | Use semicolons judiciously. |
| packages/cloudflare_logpush/docs/README.md | 665 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/cloudflare_logpush/docs/README.md | 1731 | Elastic.WordChoice | Consider using 'top-level' instead of 'first-class', unless the term is in the UI. |
| packages/cloudflare_logpush/docs/README.md | 2377 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/cloudflare_logpush/docs/README.md | 3089 | Elastic.Wordiness | Consider using 'whether' instead of 'Whether or not'. |
The Vale linter checks documentation changes against the Elastic Docs style guide.
To use Vale locally or report issues, refer to Elastic style guide for Vale.
| - description: Ingest pipeline improvements. | ||
| type: enhancement | ||
| link: https://github.com/elastic/integrations/pull/19163 |
There was a problem hiding this comment.
Do you mean 19234 this PR? 19163 is going to be closed.
I'm not sure if we want to callout this PR too - because its just a consolidation of all the below ones.
@efd6 WDYT?
💚 Build Succeeded
|
| target_field: cloudflare_logpush.access_request.country | ||
| ignore_missing: true | ||
| - set: | ||
| tag: set_client_geo_country_name_cc252be1 |
There was a problem hiding this comment.
🟡 MEDIUM data_stream/access_request/.../default.yml:149
client.geo.country_name set from lowercase ISO code
The set processor copies cloudflare_logpush.access_request.country (a lowercase ISO-3166 alpha-2 code such as "us" per the test fixture test-pipeline-access-request.log) directly into client.geo.country_name. The subsequent geoip processor at line 183 uses default override=true and silently masks this for IPs MaxMind can resolve, but for private/unresolvable IPs the field is left holding a lowercase ISO code instead of a human-readable name. client.geo.country_iso_code is the correct ECS target for an ISO code.
Recommendation:
Either drop the manual set and rely on geoip alone, or normalize the value into country_iso_code:
- uppercase:
tag: uppercase_country_iso_code_from_cloudflare_logpush_access_request_country
field: cloudflare_logpush.access_request.country
target_field: client.geo.country_iso_code
ignore_missing: trueThen remove the existing set that targets client.geo.country_name.
🤖 AI-Generated Review | Vera Review Bot
⚠️ Automated review — verify suggestions before applying.
| target_field: cloudflare_logpush.gateway_http.proxy_endpoint | ||
| ignore_missing: true | ||
| - convert: | ||
| tag: convert_json_Quarantined_to_cloudflare_logpush_gateway_http_quarantined_f31dfd9b |
There was a problem hiding this comment.
🟡 MEDIUM data_stream/gateway_http/.../default.yml:498
convert type: boolean writes to keyword-declared field (gateway_http.quarantined)
The convert processor sets cloudflare_logpush.gateway_http.quarantined with type: boolean, but data_stream/gateway_http/fields/fields.yml:115-117 declares quarantined as type: keyword. Elasticsearch coerces the boolean to the string "true"/"false" on indexing, which breaks boolean queries (e.g., quarantined: true) and is inconsistent with the sibling isolated field declared type: boolean.
Recommendation:
Align the field declaration with the convert type. Update fields/fields.yml:115-117:
- name: quarantined
type: boolean
description: If the request content was quarantined.🤖 AI-Generated Review | Vera Review Bot
⚠️ Automated review — verify suggestions before applying.
| field: error.message | ||
| value: |- | ||
| Processor "{{{ _ingest.on_failure_processor_type }}}" in pipeline "{{{ _ingest.on_failure_pipeline }}}" failed with message "{{{ _ingest.on_failure_message }}}" | ||
| value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.on_failure_pipeline}}} failed with message: {{{_ingest.on_failure_message}}}' |
There was a problem hiding this comment.
🔵 LOW data_stream/access_request/.../default.yml:343
Global on_failure block partially tagged (all 21 data streams)
The PR added tags to the set event.kind processor inside each pipeline's top-level on_failure block, but the two surrounding append processors (one for error.message, one for tags) remain untagged. This is inconsistent with the otherwise comprehensive tagging applied across the rest of each pipeline. The same partial-tagging pattern is present in all 21 data-stream pipelines under data_stream/*/elasticsearch/ingest_pipeline/default.yml.
Recommendation:
Add tag: keys to the two append processors in the global on_failure block of every data-stream pipeline:
on_failure:
- append:
tag: append_pipeline_error_message
field: error.message
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.on_failure_pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
- set:
tag: set_pipeline_error_to_event_kind
field: event.kind
value: pipeline_error
- append:
tag: append_preserve_original_event_tag
field: tags
value: preserve_original_event
allow_duplicates: false🤖 AI-Generated Review | Vera Review Bot
⚠️ Automated review — verify suggestions before applying.
Proposed commit message
Checklist
changelog.ymlfile.How to test this PR locally
Related issues