EntityAnalytics AD: add support for ECS entity fields#18337
EntityAnalytics AD: add support for ECS entity fields#18337chemamartinez wants to merge 7 commits intoelastic:mainfrom
Conversation
Vale Linting ResultsSummary: 2 warnings found
|
| File | Line | Rule | Message |
|---|---|---|---|
| packages/entityanalytics_ad/docs/README.md | 350 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/entityanalytics_ad/docs/README.md | 351 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
The Vale linter checks documentation changes against the Elastic Docs style guide.
To use Vale locally or report issues, refer to Elastic style guide for Vale.
| if: ctx.activedirectory?.device?.last_logon_timestamp != null && ctx.activedirectory.device.last_logon_timestamp != '' | ||
| on_failure: | ||
| - append: |
There was a problem hiding this comment.
🟠 High ingest_pipeline/device.yml:120
The date processor for activedirectory.device.last_logon_timestamp (lines 114-124) lacks a - remove: step in its on_failure handler. When date parsing fails, the original string remains in the field, and since entityanalytics_ad.device.last_logon_timestamp is mapped as type: date, Elasticsearch will reject the document. This causes the document to be dropped. The other three date processors in this file (lines 75-87, 88-100, 101-113) all include the remove step in their on_failure handlers.
on_failure:
+ - remove:
+ field: activedirectory.device.last_logon_timestamp
- append:🤖 Copy this AI Prompt to have your agent fix this:
In file packages/entityanalytics_ad/data_stream/entity/elasticsearch/ingest_pipeline/device.yml around lines 120-122:
The `date` processor for `activedirectory.device.last_logon_timestamp` (lines 114-124) lacks a `- remove:` step in its `on_failure` handler. When date parsing fails, the original string remains in the field, and since `entityanalytics_ad.device.last_logon_timestamp` is mapped as `type: date`, Elasticsearch will reject the document. This causes the document to be dropped. The other three date processors in this file (lines 75-87, 88-100, 101-113) all include the `remove` step in their `on_failure` handlers.
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
Proposed commit message
Checklist
changelog.ymlfile.Related issues