-
Notifications
You must be signed in to change notification settings - Fork 23
Update upstream OpenTelemetry agent dependencies to 2.22.0 #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update upstream OpenTelemetry agent dependencies to 2.22.0 #898
Conversation
... encies Made with ❤️️ by updatecli
|
closes #889 |
| @Override | ||
| public void onStartupSuccess() {} | ||
| public void onStartupSuccess() { | ||
| Slf4jInternalLogger.initializationComplete = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[minor] I think it would be better too expose a setInitializationComplete() method rather than directly expose the volatile boolean, it could also ensure that it's called at most once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree. I've changed to a method. I thought about an error or guard but actually it doesn't matter if it's called more than once, the only thing to avoid is setting it back to false, which can't be done with a no-arg setter. change applied
5c24e48
@elastic/apm-agent-java, can you please check and merge this PR?
Upgrade the upstream agent version and related transitive dependencies
Update upstream OpenTelemetry agent version and related dependencies
ran shell command "gradle/update-upstream.sh v2.22.0 && echo \"Update successful\""
v2.22.0
Created automatically by Updatecli
Options:
Most of Updatecli configuration is done via its manifest(s).
Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!