Clarify loadbalancer recommendation and keepalive sysctl settings#5324
Clarify loadbalancer recommendation and keepalive sysctl settings#5324
Conversation
✅ Vale Linting ResultsNo issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
Elasticsearch will override |
yetanothertw
left a comment
There was a problem hiding this comment.
Thank you for working on this PR!
I've added a couple of minor suggestions, but looks good otherwise.
Co-authored-by: Vlada Chirmicci <vlada.chirmicci@elastic.co>
Co-authored-by: Vlada Chirmicci <vlada.chirmicci@elastic.co>
Thank you @DaveCTurner! I am sorry if anything was missing in the communication, but I came here based on two things below: [1]
Where he wrote down below 3 lines indicating the 3 values are from the PR linked:
[2] That was in 2020, and everyone's discussion was based on that later, and no one actually said the value was not appropriate.
Which indicates we should make some change other than default. I understand you didn't mention yes or no to original parameter values. The above [1] apparently mentioned the value other than default (ES suggests) and [2] logically made me took it as those value sets are the ones that ES team was suggesting... Sorry for the back and forth, but if possible, may I trouble you to please shed some insights on what are the recommended value we should actually use? We'd be love to make ourselves understand things correctly. Thanks in advance! |
|
The really vital one is I support reducing the timeouts for keepalives too although this is (a) less impactful and (b) overridden by ES in most cases anyway. I do not have a strong argument for reducing |
Clarified the responsibility for load balancer provisioning and configuration, and updated language for better readability. Including an interesting paragraph by @kunisen in the cancelled PR #5324 @kunisen , let me know your thoughts, I've added it on top of the page and not just on the algorithms paragraph. I think it was a good addition.
|
Thanks @DaveCTurner again! Regarding Dave your comment
Thank you!
Noted. Given you said Note: I will not describe => Dave, may I trouble you to kindly check again and see if this is still confusing or not please? 🙏 Side note: ES setting & ECE settingAlso I understand you might have question why we want to add this to ECE sysctl setting config where it takes effect on all containers in addition to ES containers only. This is verified by our ECE dev in https://github.com/elastic/sdh-control-plane/issues/12444#issuecomment-3961376807, that So ECE dev agreed that we could use these settings and set it at ECE host level. Please let me know if anything is missing, and thanks again for your patience. |
remove net.ipv4.tcp_keepalive_probes per ES dev's confirmation
|
That seems fine from the ES side, although tbc this is not the ES team recommending these particular settings values, we just don't care about them because ES overrides the system defaults on a per-connection basis. There are some claims above that these values are also derived from elastic/elasticsearch#59278 but I don't think that's correct. |
Summary
Background ticket: https://github.com/elastic/support-tech-lead/issues/1747#issuecomment-3982265243, https://github.com/elastic/sdh-control-plane/issues/12444#issuecomment-3973989792
Doc update details
[1] ECE loadbalancer algorithm and responsibility
Discussion and background: https://github.com/elastic/sdh-control-plane/issues/12444#issuecomment-3974287615
TL;DR:
@ChallenHB @bobbybho may I trouble you to please review the content from ECE perspective?
[2] ES container sysctl settings according to ES recommendation in ECE doc
Discussion: https://github.com/elastic/sdh-control-plane/issues/12444#issuecomment-3973989792
Background:
TL;DR:
@DaveCTurner may I trouble you to please review the content from ECE perspective? This is based on your clear suggestion in this comment - https://github.com/elastic/cloud/issues/68217#issuecomment-1847097504 back in 2023. Thank you!
@ChallenHB may I also trouble you to please review from ECE perspective and see if the way of mentioning these keepalive relevant settings are appropriate?
Generative AI disclosure
Doc view / Preview
Before merge
After merge