-
Notifications
You must be signed in to change notification settings - Fork 193
Revise vm.max_map_count recommendation in bootstrap checks #4447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updated the recommended value for vm.max_map_count to 1048576.
✅ Vale Linting ResultsNo issues found on modified lines! |
🔍 Preview links for changed docs |
|
Thank you @shainaraskas for opening this one. I missed to find we also have one mention in bootstrap. But this is not true yet - I am asking in this internal comment to ES dev about whether we should change our bootstrap code to set it higher. Currently it's still
We are waiting on @mark-vieira and other ES team to confirm they want to carry out this change too, and if so, then we will likely have the value reflected to latest 8.18, 8.19 (as IIUC both minors are under maintenance) and 9.x docs. I don't have a good idea about what we should do to this PR, but maybe we could wait until ES dev friend comes back after holiday season and discuss together? WDYT? |
kunisen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some quick comments and set it to "Request changes" to make sure we have a clear direction before merging it. 🙏
|
@kunisen the change I made doesn't change the bootstrap check value. instead, it only states that the bootstrap check value is different from the suggested value, and leaves the bootstrap check value the same. let me know what you think. |
|
Thank you @shainaraskas I am good with your change. Let's change it for now. |
Summary
Updated the recommended value for vm.max_map_count to 1048576 in the bootstrap check docs
Generative AI disclosure