-
Notifications
You must be signed in to change notification settings - Fork 42
copy entity to user & hosts structs #3791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This pull request does not have a backport label. Could you fix it @chennn1990? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 A few notes:
- Let’s validate this on GCP and Azure before merging.
- We should open a ticket to remove the redundant
entity.*fields for host and user entities once we pivot touser|host.entity.id. This can be tracked as an action item under elastic/kibana#233603. - There are currently no mappings for these fields. we’ll need to add them in the integrations repo:
- Please don't backport to
9.3
| Name: vmProperties.Extended.InstanceView.ComputerName, | ||
| Type: vmProperties.HardwareProfile.VmSize, | ||
| } | ||
| asset.Host.Entity = &asset.Entity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary related to your changes, but I wonder why we don't use the inventory.WithHost utility here.
Summary of your changes
Asset Inventory change:
create a nested hierarchy inside User & Host so the entity will be appeared also there instead of a sibling.
Related Issues
[Asset Discovery] Migrate to new nested
*.entity.*schema #3554[Entity Store] Support
*.entity.idfields on transform pivot kibana#233603Checklist