Skip to content

Conversation

@chennn1990
Copy link

@chennn1990 chennn1990 commented Dec 24, 2025

Summary of your changes

Asset Inventory change:
create a nested hierarchy inside User & Host so the entity will be appeared also there instead of a sibling.

Related Issues

Checklist

  • I have added tests that prove my fix is effective or that my feature works

@chennn1990 chennn1990 requested a review from a team as a code owner December 24, 2025 12:11
@mergify
Copy link

mergify bot commented Dec 24, 2025

This pull request does not have a backport label. Could you fix it @chennn1990? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

Copy link
Collaborator

@uri-weisman uri-weisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 A few notes:

  1. Let’s validate this on GCP and Azure before merging.
  2. We should open a ticket to remove the redundant entity.* fields for host and user entities once we pivot to user|host.entity.id. This can be tracked as an action item under elastic/kibana#233603.
  3. There are currently no mappings for these fields. we’ll need to add them in the integrations repo:
  4. Please don't backport to 9.3

Name: vmProperties.Extended.InstanceView.ComputerName,
Type: vmProperties.HardwareProfile.VmSize,
}
asset.Host.Entity = &asset.Entity
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary related to your changes, but I wonder why we don't use the inventory.WithHost utility here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants