Skip to content

Conversation

@colleenmcginnis
Copy link
Contributor

Fixes image paths to work with docs-assembler.

Notes for the reviewer:

  • I was not able to get images in reference, extend, or release-notes to work using the :::{image} syntax because it seems to resolve differently than the Markdown ![]() syntax. We should address this in docs-builder, but in order to get images working as soon as possible, I've used Markdown syntax and left us a TO DO in a code comment to add back the screenshot class where applicable.

@colleenmcginnis colleenmcginnis added docs Team:Docs Label for the Observability docs team labels Apr 15, 2025
@colleenmcginnis colleenmcginnis requested a review from a team April 15, 2025 22:22
@colleenmcginnis colleenmcginnis self-assigned this Apr 15, 2025
Copy link

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐜

@colleenmcginnis colleenmcginnis merged commit b40bcd7 into elastic:main Apr 15, 2025
5 of 6 checks passed
@colleenmcginnis colleenmcginnis deleted the fix-images-when-assembled branch April 15, 2025 22:53
jclusso added a commit to jclusso/apm-agent-ruby that referenced this pull request Apr 22, 2025
…1531

* add-transaction-name-sampling-config:
  Add ability to configure sampling rate based on transaction span name
  Updates to allow tests to pass (elastic#1541)
  fix image paths for docs-assembler (elastic#1538)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-ruby docs Team:Docs Label for the Observability docs team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants