test(knex): fix TAV tests for knex#5069
Merged
Merged
Conversation
knex version 3.2.0 to 3.2.7 (inclusive) includes an "exports"
in package.json that broke deep-package imports. That was reverted
in 3.2.8, because apparently there are some use cases for knex
users doing deep package imports.
In our case, we were doing `require('knex/package')` in tests only
for getting the package version. While the "exports" existed there
was a mapping for "./package.json", so the workaround for us is simple.
🤖 GitHub commentsJust comment with:
|
david-luna
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
knex version 3.2.0 to 3.2.7 (inclusive) includes an "exports"
in package.json that broke deep-package imports. That was reverted
in 3.2.8, because apparently there are some use cases for knex
users doing deep package imports.
In our case, we were doing
require('knex/package')in tests onlyfor getting the package version. While the "exports" existed there
was a mapping for "./package.json", so the workaround for us is simple.
Refs: knex/knex#6422
TAV tests for knex are failing on knex@3.2.7.
E.g. https://github.com/elastic/apm-agent-nodejs/actions/runs/25679762074/job/75392718232#step:3:307
Local repro: