docs + security: blog posts, Cursor guide, benchmark clarification, nosemgrep fixes#59
Merged
rajkumarsakthivel merged 5 commits intomainfrom May 8, 2026
Merged
docs + security: blog posts, Cursor guide, benchmark clarification, nosemgrep fixes#59rajkumarsakthivel merged 5 commits intomainfrom
rajkumarsakthivel merged 5 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to suppress external SQL-injection findings (reported as false positives) by annotating dynamic SQL usages with # noqa: S608 and adding brief “safe because …” explanations, without changing any SQL behavior.
Changes:
- Added
# noqa: S608suppressions to several SQLite.execute(...)calls that use f-strings. - Added safety-explanation comments describing why interpolated parts are non-user-controlled / parameterized.
- Applied these annotations across vector/graph/FTS stores, embedding cache cleanup, and memory DB helpers.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/context_engine/storage/vector_store.py | Adds S608 suppressions/comments around dynamic SQL for vec table creation and batched deletes. |
| src/context_engine/storage/graph_store.py | Adds S608 suppressions/comments around batched selects/deletes using IN (...) placeholder lists. |
| src/context_engine/storage/fts_store.py | Adds S608 suppression/comment for batched delete by file paths. |
| src/context_engine/memory/db.py | Adds S608 suppressions/comments for dynamic table/column SQL in vec writes and retention pruning. |
| src/context_engine/indexer/embedding_cache.py | Adds S608 suppression/comment for batched delete of orphaned cache rows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fazleelahhee
previously approved these changes
May 7, 2026
fazleelahhee
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Blog posts:
README:
Security:
noqa: S608tonosemgrep: sqlalchemy-execute-raw-queryacross 5 files (Copilot review feedback on semgrep suppression)SEO: