Skip to content

feat: add fargate profile support for EKS internal endpoint #8694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HusainZafar wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −3
Open

feat: add fargate profile support for EKS internal endpoint #8694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions pkg/cfn/builder/beta.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,3 +251,17 @@ func addBetaAccessEntry(stackName string, accessEntryType string) *gfn.CustomRes
customResource.Properties["Type"] = gfnt.NewString(accessEntryType)
return customResource
}

func createBetaFargateAssumeRolePolicy(sourceArnCondition cft.MapOfInterfaces) interface{} {
statements := []cft.MapOfInterfaces{
{
"Effect": "Allow",
"Principal": cft.MapOfInterfaces{
"Service": "eks-fargate-pods.aws.internal",
},
"Action": "sts:AssumeRole",
"Condition": sourceArnCondition,
},
}
return cft.MakePolicyDocument(statements...)
}
14 changes: 11 additions & 3 deletions pkg/cfn/builder/fargate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,19 @@ func addResourcesForFargate(rs *resourceSet, cfg *api.ClusterConfig) error {
return fmt.Errorf("restricting access based on SourceArn: %w", err)
}

role := &gfniam.Role{
AssumeRolePolicyDocument: cft.MakeAssumeRolePolicyDocumentForServicesWithConditions(
var assumeRolePolicyDocument interface{}
if cfg.IsCustomEksEndpoint() {
// Use beta assume role policy for beta stacks with Fargate-specific service principals
assumeRolePolicyDocument = createBetaFargateAssumeRolePolicy(sourceArnCondition)
} else {
assumeRolePolicyDocument = cft.MakeAssumeRolePolicyDocumentForServicesWithConditions(
sourceArnCondition,
MakeServiceRef("EKSFargatePods"), // Ensure that EKS can schedule pods onto Fargate.
),
)
}

role := &gfniam.Role{
AssumeRolePolicyDocument: assumeRolePolicyDocument,
ManagedPolicyArns: gfnt.NewSlice(makePolicyARNs(
iamPolicyAmazonEKSFargatePodExecutionRolePolicy,
)...),
Expand Down
Loading