Skip to content

Conversation

@nopbody
Copy link

@nopbody nopbody commented Dec 25, 2025

Closes #799

added proper end-to-end integration tests for the bitcoin-wallet crate by running real Bitcoin services inside Docker instead of mocks. It spins up a regtest bitcoind with electrs and verifies core wallet flows like receiving, sending, broadcasting, and confirming transactions. This helps catch real-world issues early and makes the wallet logic much more reliable.

@binarybaron Follow-ups / WHICH cases to add next (tracking list)?

@nopbody
Copy link
Author

nopbody commented Dec 29, 2025

@binarybaron, this approach matches the repo’s existing integration test patterns, All tests pass reliably on clean Docker setups; failures are clear if Docker isn’t running.
Do you have anything particular/specific about this that feels off? - any edge cases or style tweaks you spot?
let me know.
thanks

@binarybaron
Copy link

@binarybaron, this approach matches the repo’s existing integration test patterns, All tests pass reliably on clean Docker setups; failures are clear if Docker isn’t running.

Do you have anything particular/specific about this that feels off? - any edge cases or style tweaks you spot?

let me know.

thanks

Will review soon. Is the PR description AI generated ?

@nopbody
Copy link
Author

nopbody commented Dec 29, 2025

used AI just to refine the wording, but the implementation and reasoning are mine.
Happy to explain any design decision or can walk you through any part if needed.

@0saurabh0
Copy link

I'd love to review/give my points on this as per #799 (comment) when this is completed, if its alright with you @binarybaron

@nopbody
Copy link
Author

nopbody commented Jan 5, 2026

Hi @binarybaron, anything we can do to escalate things here?
thanks

@binarybaron
Copy link

Hi @binarybaron, anything we can do to escalate things here? thanks

Not really. We will review this when we find the time. Thank you though.

Can you re-write the description yourself or delete it entirely? If I want a AI summary I can run Claude Code myself.

@nopbody
Copy link
Author

nopbody commented Jan 5, 2026

Not really. We will review this when we find the time. Thank you though.

NP

Can you re-write the description yourself or delete it entirely? If I want a AI summary I can run Claude Code myself.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[0.75 XMR] Integration tests for bitcoin_wallet

3 participants