Fix walrus operator in assert statement, leading to problems with optimized code#407
Open
henrykrumb wants to merge 5 commits into
Open
Fix walrus operator in assert statement, leading to problems with optimized code#407henrykrumb wants to merge 5 commits into
henrykrumb wants to merge 5 commits into
Conversation
* Add RoMa to requirements * Switch to RoMa backend for rotation geodesic * Fix environment.yml * Add roma to pip requirements
This reverts commit 506d786.
* Add roma to dependencies * Add rotation matrix check in inverse * Make Rigid.Transform__getitem__ return a RigidTransform * Change check from rotation to orthonormal * Add roma to requirements * Roll back Rigid.Transform__getitem__ return a RigidTransform
* If input is RigidTransform, return input * Remove hardcoded class name * Make slicing return a RigidTransform * Add a matmul overload
Owner
|
hi henry, thanks for the PR! never knew about the I think you just need to run apologies for the nbdev framework, I though it was a great idea a few years ago but now i realize how challenging it makes PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the optimization flag -O with the Python interpreter eliminates assert statements. Thus, asserts should have no side-effects.
This small PR moves the inline assignment operator (walrus) out of an assert-statement to make it free of side-effects, so that it can be run in deployments where the -O flag is used.
Change is applied both in the original notebook and exported python module code.