🐛 fix the hybrid browser toolkit issue #879
Conversation
|
Hi，can you successfully run browsertoolkit after modification？ |
| default_start_url="about:blank", | ||
| cdp_url=f"http://localhost:{env('browser_port', '9222')}", | ||
| # cdp_url=f"http://localhost:{env('browser_port', '9222')}", | ||
| connect_over_cdp=False, | ||
| enabled_tools=[ |
There was a problem hiding this comment.
"Thanks @a7m-1st ! Good catch on the connect_over_cdp setting. then how about the Azure configuration?
There was a problem hiding this comment.
I think we can still merge it though until the cdp branch is merged : )
Regarding azure I have reviewed a similar PR, does this fix it?
#873
|
a7m-1st
left a comment
a7m-1st
left a comment
There was a problem hiding this comment.
All in all if ever other thing is just refactoring then we can have a patch for the hybrid browser till the feature branch is merged to sync with latest camel version.
|
Close since we better resubmit an updated PR for the linter changes after the other features have been merged. |
Description
1. Fix Azure OpenAI Model Initialization
Fixed two issues when using Azure OpenAI models:
api_version: Now properly passed toModelFactory.create()as initialization parameterazure_deployment_nameusage: Fixed parameter being incorrectly passed to API calls instead of model initializationSolution: Updated
agent_model()to separate Azure initialization parameters (api_version,azure_deployment_name) from API call parameters. Azure params are now passed as direct kwargs toModelFactory.create().2. Update HybridBrowserToolkit Connection Mode
Changed
HybridBrowserToolkitinitialization insearch_agent()to useconnect_over_cdp=Falseinstead of CDP connection mode.Related Files:
backend/app/utils/agent.py:agent_model()to handle Azure OpenAI parameters correctlysearch_agent()to setconnect_over_cdp=FalseforHybridBrowserToolkitWhat is the purpose of this pull request?