fix: handle world volume as requested part in npdet_to_dot#71
Open
wdconinc wants to merge 3 commits into
Open
Conversation
When the world volume name is passed as a part filter in npdet_to_dot, all level-1 children should qualify as within that subtree. Previously, the traversal logic only matched level-1 nodes against the requested part names, so specifying the world volume name produced an empty graph. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes npdet_to_dot “part mode” traversal so that when the world volume name is provided as a requested part, the tool correctly includes all level-1 children as being inside that subtree (previously producing an empty graph).
Changes:
- Pre-checks whether the world volume name is included in the requested part filters.
- When the world is requested, treats every level-1 child as qualifying for traversal under the selected max depth.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Capybara summary for PR 71
|
wdconinc
moved this to In Review
in ePIC Review Board (auto-populated; changes will be discarded)
wdconinc
moved this from In Review
to Needs Review
in ePIC Review Board (auto-populated; changes will be discarded)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
When the world volume name is passed as a part filter to
npdet_to_dot, all level-1 children should qualify as being within that subtree. Previously the traversal logic only matched level-1 nodes against the requested part names, so specifying the world volume name produced an empty graph. This fix pre-checks whether the world volume itself is among the requested parts and, if so, marks every level-1 child as matching.What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply
GitHub Copilot was used to create the commit and open this PR.