feat: show assembly volumes with dashed border in npdet_to_dot#70
Open
wdconinc wants to merge 1 commit into
Open
feat: show assembly volumes with dashed border in npdet_to_dot#70wdconinc wants to merge 1 commit into
wdconinc wants to merge 1 commit into
Conversation
Assembly volumes (TGeoVolumeAssembly) are now rendered with a dashed box outline in the DOT output to visually distinguish them from regular encapsulating volumes, which keep a solid border. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates npdet_to_dot so generated Graphviz output visually distinguishes TGeoVolumeAssembly nodes from regular volumes by rendering assemblies with dashed borders.
Changes:
- Documents the dashed-border convention for assembly volumes in the tool header comment.
- Adds per-node DOT
styleoutput, usingfilled,dashedfor assemblies andfilledotherwise.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Now looks like this: |
Capybara summary for PR 70
|
wdconinc
moved this to In Review
in ePIC Review Board (auto-populated; changes will be discarded)
wdconinc
moved this from In Review
to Needs Review
in ePIC Review Board (auto-populated; changes will be discarded)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
The
npdet_to_dottool previously rendered all volumes identically regardless of their type. This PR makes assembly volumes (TGeoVolumeAssembly) render with a dashed box outline, visually distinguishing them from regular encapsulating volumes (solid border).What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply