Smart tracking volume#69
Draft
DraTeots wants to merge 18 commits into
Draft
Conversation
…t-tracking-volume
Contributor
Author
|
Will now put some plots how this affect stuff |
Capybara summary for PR 69
|
wdconinc
reviewed
May 29, 2026
wdconinc
reviewed
May 29, 2026
| /// are dropped (p.reason = 0), subject to the must-keep guards in end(). | ||
| /// Defaults match the legacy tracker_region_zmax / tracker_region_zmin | ||
| /// constants from epic/compact/tracking_region.xml. | ||
| double m_forwardZ{335 * dd4hep::cm}; ///< +Z dead-zone boundary (positive) |
Contributor
There was a problem hiding this comment.
Explicit geometry values should be gotten from geometry, not hardcoded here.
wdconinc
reviewed
May 29, 2026
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
Adds a new DD4hep/Geant4 plugin
Geant4TVEicParticleHandlerinnpsim/src/plugins/. It runs the standard tracking-volume filter (verbatimfrom upstream
Geant4TVUserParticleHandler) and then layers an EIC-specificregional cut: drop particles ending at
endZ > ForwardRegionZorendZ < BackwardRegionZwhose |p| is below the configured threshold,unless they are primary,
KEEP_ALWAYS, or made a tracker hit. Calorimeterhits are optionally protected via the
KeepCaloHitParticlesproperty(default off — matches upstream policy and reduces shower bloat).
Configurable plugin properties (all in DD4hep units):
ForwardRegionZ(default+335 cm),BackwardRegionZ(-175 cm),ForwardMomentumMin(100 MeV),BackwardMomentumMin(100 MeV),KeepCaloHitParticles(false).User-facing doc:
npsim/src/plugins/doc/Geant4TVEicParticleHandler.md.Closes #__.
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply
SIM.part.userParticleHandler = "Geant4TVEicParticleHandler".)There are several considerations made: