chore: fjcontrib-1.101#300
Open
wdconinc wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the EIC container Spack configuration to pick up fjcontrib v1.101 (including the Centauro performance update) by (1) pinning the fjcontrib version constraint and (2) advancing the pinned eic/eic-spack repository commit used during builds.
Changes:
- Bump
fjcontribrequirement from@1.051to@1.101in the sharedspack-environment/packages.yaml. - Update
EICSPACK_VERSIONineic-spack.shto a newereic/eic-spackcommit hash.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spack-environment/packages.yaml | Updates the fjcontrib version constraint to @1.101. |
| eic-spack.sh | Advances the pinned eic/eic-spack commit used by container builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR upgrades
fjcontribto v1.101, including a performance upgrade to the Centauro implementation.What is the urgency of this PR?
What kind of change does this PR introduce?
fjcontribv1.101)Please check if any of the following apply