feat: add glibc hwcaps multi-arch support#299
Open
wdconinc wants to merge 6 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds glibc hwcaps runtime dispatch support by requiring hwcaps=x86_64_v3 for clhep, fastjet, lhapdf, and vecgeom, and bumps the eic/eic-spack pin to pick up the corresponding package recipe changes from eic/eic-spack#933.
Changes:
- Add
hwcaps=x86_64_v3requirement to four packages inpackages.yaml. - Update
EICSPACK_VERSIONto the commit providing the newhwcapsvariant.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spack-environment/packages.yaml | Require hwcaps=x86_64_v3 for clhep, fastjet, lhapdf, vecgeom |
| eic-spack.sh | Bump EICSPACK_VERSION to commit with hwcaps variant support |
…CLHEP, VecGeom, FastJet
…CLHEP, VecGeom, FastJet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR picks up the experimental functionality in eic/eic-spack#933 that adds glibc hwcaps runtime dispatch support to select libraries (clhep, fastjet, lhapdf, vecgeom).
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply