Skip to content

feat: epic 26.03.0#184

Merged
veprbl merged 4 commits intomasterfrom
pr/epic_26_03_0
Mar 6, 2026
Merged

feat: epic 26.03.0#184
veprbl merged 4 commits intomasterfrom
pr/epic_26_03_0

Conversation

@veprbl
Copy link
Copy Markdown
Member

@veprbl veprbl commented Mar 6, 2026

@veprbl veprbl requested review from Copilot and wdconinc March 6, 2026 05:07
Copy link
Copy Markdown
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're keeping 25.10, I think we should keep 25.11 too for continuity.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the EPIC Spack environments to include EPIC release 26.03.0 and bumps the pinned key4hep-spack revision accordingly.

Changes:

  • Add epic@26.03.0 to the XL and CUDA Spack environment specs.
  • Remove epic@25.11.x entries from both environment spec lists.
  • Update the pinned KEY4HEPSPACK_VERSION commit hash.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
spack-environment/xl/epic/spack.yaml Adds EPIC 26.03.0 to the XL environment and prunes 25.11.x entries.
spack-environment/cuda/epic/spack.yaml Adds EPIC 26.03.0 to the CUDA environment and prunes 25.11.x entries.
key4hep-spack.sh Updates the pinned key4hep-spack commit to align with the release update.

@veprbl
Copy link
Copy Markdown
Member Author

veprbl commented Mar 6, 2026

If we're keeping 25.10, I think we should keep 25.11 too for continuity.

I was hoping to eventually remove all geometries but the last one. I had to keep 25.10 because of preTDR argument.

Copilot AI review requested due to automatic review settings March 6, 2026 05:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@veprbl
Copy link
Copy Markdown
Member Author

veprbl commented Mar 6, 2026

@wdconinc is this okay now?

@veprbl veprbl merged commit b33ac28 into master Mar 6, 2026
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants