Conversation
wdconinc
reviewed
Mar 6, 2026
Contributor
wdconinc
left a comment
There was a problem hiding this comment.
If we're keeping 25.10, I think we should keep 25.11 too for continuity.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the EPIC Spack environments to include EPIC release 26.03.0 and bumps the pinned key4hep-spack revision accordingly.
Changes:
- Add
epic@26.03.0to the XL and CUDA Spack environment specs. - Remove
epic@25.11.xentries from both environment spec lists. - Update the pinned
KEY4HEPSPACK_VERSIONcommit hash.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spack-environment/xl/epic/spack.yaml | Adds EPIC 26.03.0 to the XL environment and prunes 25.11.x entries. |
| spack-environment/cuda/epic/spack.yaml | Adds EPIC 26.03.0 to the CUDA environment and prunes 25.11.x entries. |
| key4hep-spack.sh | Updates the pinned key4hep-spack commit to align with the release update. |
Member
Author
I was hoping to eventually remove all geometries but the last one. I had to keep 25.10 because of preTDR argument. |
Member
Author
|
@wdconinc is this okay now? |
wdconinc
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/eic/epic/releases/tag/26.03.0