Skip to content

Conversation

@epwn
Copy link
Contributor

@epwn epwn commented Jan 7, 2016

Adds steps to prepare baremetals before running site.yml
Note: cleaned up some code

Adds steps to prepare baremetals before running site.yml
Note: cleaned up some code
@pwplusnick
Copy link
Collaborator

I'm going to let @CullenTaylor handle this one since it is more in his domain.

@epwn
Copy link
Contributor Author

epwn commented Jan 7, 2016

@pwplusnick could i get a code review?

@davidcusatis
Copy link
Collaborator

-100000 for removing "the biz" comment

@eggshell
Copy link
Owner

eggshell commented Jan 8, 2016

Yeah that's bunz. Not sure if we really need the code to allow unauthenticated repos. I never bother with that. Can you explain the reasoning behind it a little more?

@davidcusatis
Copy link
Collaborator

that was some shit we had to do for package installs a while ago, i always ran it regardless. and it doesn't get run if unless you specify to do so fwiw. but that block is not just authenticating repos, the ssh keygen is the reason why anyone would use the script for the most part.

@epwn
Copy link
Contributor Author

epwn commented Jan 8, 2016

my block also runs a sanity check to make sure sdb is parted correctly

@epwn epwn closed this Jan 8, 2016
@epwn epwn reopened this Jan 8, 2016
@epwn
Copy link
Contributor Author

epwn commented Jan 8, 2016

whoops. close and comment should not be on the left

@pwplusnick
Copy link
Collaborator

@epwn Right?

@pwplusnick
Copy link
Collaborator

@epwn As far as the code goes it lgtm. I just want @CullenTaylor to have the final say on this one, since he is vastly more experienced with that kind of deployment task.

@epwn
Copy link
Contributor Author

epwn commented Jan 9, 2016

For sure. Thanks pwp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants