-
Notifications
You must be signed in to change notification settings - Fork 4
Add prepare baremetal steps #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Adds steps to prepare baremetals before running site.yml Note: cleaned up some code
|
I'm going to let @CullenTaylor handle this one since it is more in his domain. |
|
@pwplusnick could i get a code review? |
|
-100000 for removing "the biz" comment |
|
Yeah that's bunz. Not sure if we really need the code to allow unauthenticated repos. I never bother with that. Can you explain the reasoning behind it a little more? |
|
that was some shit we had to do for package installs a while ago, i always ran it regardless. and it doesn't get run if unless you specify to do so fwiw. but that block is not just authenticating repos, the ssh keygen is the reason why anyone would use the script for the most part. |
|
my block also runs a sanity check to make sure sdb is parted correctly |
|
whoops. close and comment should not be on the left |
|
@epwn Right? |
|
@epwn As far as the code goes it lgtm. I just want @CullenTaylor to have the final say on this one, since he is vastly more experienced with that kind of deployment task. |
|
For sure. Thanks pwp |
Adds steps to prepare baremetals before running site.yml
Note: cleaned up some code