Open
Conversation
Removed invalid EF line Added sky130B capability Maybe filename should be changed from sky130A.magicrc to sky130.magicrc but that requires a change to the Makefile too.
RTimothyEdwards
approved these changes
Aug 5, 2022
Contributor
RTimothyEdwards
left a comment
RTimothyEdwards
left a comment
There was a problem hiding this comment.
I think it makes more sense if there's a sky130B.magicrc instead of having a sky130A.magicrc that redirects, as it were, to the sky130B PDK. Or maybe more direct, just parse the A or B out of PDKPATH and use that to set PDK, since they must match.
But as a quick-and-dirty fix, this should correct the issue.
Would like to know how EF got into the script, and how it managed to get pushed to the repository without being noticed. It should have broken multiple CIs.
Contributor
|
@RTimothyEdwards Should we merge this? |
Contributor
|
@marwaneltoukhy : That's really a question for @d-m-bailey . |
Contributor
Author
|
@marwaneltoukhy I think this PR is still necessary. Especially for sky130B. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed invalid EF line
Added sky130B capability
Maybe filename should be changed from sky130A.magicrc to sky130.magicrc
but that requires a change to the Makefile too.
Fixes #135