chore(deps-dev): bump ts-morph from 26.0.0 to 28.0.0#538
chore(deps-dev): bump ts-morph from 26.0.0 to 28.0.0#538dependabot[bot] wants to merge 1 commit into
Conversation
28ca3d6 to
e33d8aa
Compare
e33d8aa to
82a7750
Compare
There was a problem hiding this comment.
Independent adversarial review (Chinese-wall)
Reviewer: minsky-reviewer[bot] via openai:gpt-5
Tier: unknown
Findings
-
[BLOCKING] package.json:peerDependencies.typescript remains "^5.0.0" while devDependencies.ts-morph is bumped to "^28.0.0"
- File: package.json (peerDependencies.typescript)
- Evidence: This PR updates only devDependencies.ts-morph from "^26.0.0" to "^28.0.0" (diff shows the change under devDependencies), but leaves peerDependencies.typescript at "^5.0.0". ts-morph 28.0.0 is a breaking release tied to TypeScript 6.0 (per the release notes linked in the PR description). This creates a version mismatch:
- Install-time: Package managers with strict peer handling (pnpm, Yarn Berry) will error or warn due to an incompatible TypeScript peer. Even if install succeeds, you will carry a broken toolchain.
- Run-time: ts-morph 28 expects TS 6 compiler APIs; with TS 5 installed, ts-morph may throw or behave incorrectly when initializing or invoking compiler API wrappers.
- Failure mode: Installing with pnpm/yarn berry likely fails with a peer dependency conflict. If it does install (npm), invoking any dev script using ts-morph will likely fail at runtime due to API/semantic mismatches.
- Required action: Update the repo’s TypeScript version to ^6.0.0 where relevant (devDependencies and/or peerDependencies), and run CI to surface any TS 6 breaking changes. If you intend to continue supporting TS 5 for consumers, explicitly decide and test a compatibility matrix; otherwise, bump peerDependencies.typescript to ^6.0.0 (or a semver range that includes 6) to reflect the new minimum.
-
[NON-BLOCKING] Lockfile not updated alongside package.json
- File: yarn.lock/package-lock.json (not present in diff)
- Evidence: The diff only shows package.json changes. If this repo commits a lockfile (yarn.lock, package-lock.json, or pnpm-lock.yaml), it should be updated to ensure reproducible installs in CI and for contributors.
- Suggestion: Commit the updated lockfile for the package manager in use.
-
[NON-BLOCKING] Node.js engine compatibility for TypeScript 6 likely needs verification
- File: package.json (engines field, if present — not shown in the diff)
- Evidence: TypeScript 6 increases minimum Node.js requirements. If the repo specifies "engines" in package.json or documents supported Node versions, those may need to be updated to match TS 6’s minimum.
- Suggestion: Confirm TS 6’s Node requirement and update package.json "engines" and CI runtime images as needed.
-
[NON-BLOCKING] Documentation/Contributing guides may need updates
- File: docs/ (not in diff)
- Evidence: Bumping to a ts-morph version that requires TS 6 changes the required local dev toolchain. Contributing/setup docs should reflect the new minimum TypeScript (and potentially Node) version.
- Suggestion: Update any setup instructions and compatibility statements.
Spec verification table
- No task spec provided. N/A
Documentation impact
- Yes. If proceeding with ts-morph 28, update:
- Supported TypeScript version(s) in README/docs and package.json peerDependencies
- Contributing/setup instructions (TypeScript 6, Node.js minimum)
- CI configuration to test on TS 6 (and optionally TS 5 if dual-support is intended)
Event: REQUEST_CHANGES
Rationale: There is a concrete, blocking incompatibility between ts-morph 28.0.0 and the current peerDependencies.typescript (^5.0.0) declared in package.json. This can cause install failures or runtime errors in dev tooling. Please align the TypeScript version (and associated docs/CI) with the ts-morph upgrade or defer the bump until ready.
82a7750 to
9d00a4a
Compare
There was a problem hiding this comment.
Independent adversarial review (Chinese-wall)
Reviewer: minsky-reviewer[bot] via openai:gpt-5
Tier: unknown
Findings
-
[BLOCKING] package.json: peerDependencies.typescript is incompatible with bumped ts-morph 28.0.0
- File: package.json (peerDependencies.typescript)
- Evidence: The diff bumps devDependencies.ts-morph to "^28.0.0" (package.json:devDependencies.ts-morph) while peerDependencies.typescript remains "^5.0.0" (package.json:peerDependencies.typescript). Per ts-morph 28.0.0 release notes in the PR description, this release is tied to TypeScript 6.0 (breaking). Keeping a TypeScript 5 peer will:
- Cause install-time peer resolution errors/warnings on strict package managers (pnpm, Yarn Berry), or pull in an incompatible TS 5.
- Lead to runtime/tooling breakage since ts-morph 28 expects TS 6 compiler APIs.
- Impact: Data-loss/correctness on developer-facing behavior (broken builds/typechecks/generation scripts). This is not purely cosmetic.
- Request: Update peerDependencies.typescript to a compatible range (for example, "^6.0.0"). If the project still needs to support TS 5 for consumers, then do not bump ts-morph to 28 or add conditional tooling to avoid ts-morph 28 on TS 5 projects.
-
[NON-BLOCKING] Validate local dev/CI toolchain consistency with TS 6
- Files: package.json (scripts.typecheck), tsconfig.json
- Evidence: Scripts use "@typescript/native-preview" for typechecking (package.json:scripts.typecheck), which may align with TS 6, but the repository does not declare a devDependency on "typescript". With ts-morph 28 requiring TS 6 and peerDependencies.typescript currently "^5.0.0", environments could end up with conflicting TypeScript versions. tsconfig.json also includes experimental options (experimentalDecorators, emitDecoratorMetadata) that have had compatibility considerations across TS versions.
- Suggestion: After bumping peerDependencies to TS 6, verify CI uses TS 6 consistently. Consider pinning a devDependency on "typescript@^6" if this is an application repo (not a library) to avoid ambiguity. If it’s a library, ensure CI installs TS 6 during checks. Also confirm tsconfig flags remain valid under TS 6.
Spec verification
- No task spec provided. N/A
Documentation impact
- Yes. If moving to TypeScript 6 is required due to ts-morph 28, update README/CONTRIBUTING to state the minimum supported TypeScript version (TS 6), and note any migration steps or caveats for contributors.
REQUEST_CHANGES
9d00a4a to
9c99511
Compare
There was a problem hiding this comment.
Independent adversarial review (Chinese-wall)
Reviewer: minsky-reviewer[bot] via openai:gpt-5
Tier: unknown
Findings
-
[BLOCKING] package.json: peerDependencies.typescript is incompatible with bumped ts-morph ^28.0.0 (requires TypeScript 6)
- File: package.json: peerDependencies.typescript (line 1+)
- Evidence: package.json devDependencies now has "ts-morph": "^28.0.0" while peerDependencies still has "typescript": "^5.0.0". ts-morph 28.0.0 release notes (linked in the PR description) state it’s tied to TypeScript 6.0 (breaking). This mismatch will:
- Trigger peer resolution errors/warnings under strict managers (pnpm/Yarn Berry).
- Risk runtime/tooling breakage in any scripts using ts-morph, as it expects TS 6 compiler APIs.
- Request: Update peerDependencies.typescript to a TS 6-compatible range (for example, "^6.0.0"). If you must retain TS 5 compatibility for consumers, do not bump ts-morph past the last TS 5-compatible version or gate its usage accordingly.
-
[NON-BLOCKING] tsconfig may need follow-up adjustments for TS 6 behavior changes
- File: tsconfig.json (line 1)
- Context: While not changed in this PR, moving to TS 6 alongside ts-morph 28 suggests reviewing:
- verbatimModuleSyntax (currently false; TS 6 defaults changed and may affect import/emit behavior).
- experimentalDecorators/emitDecoratorMetadata usage under TS 6’s decorator changes.
- Module resolution and typeRoots/types defaults.
- Suggestion: After updating the TS peer to 6, validate builds and adjust config if necessary.
Spec verification
- Bump ts-morph from 26.0.0 to 28.0.0 — Met
- Evidence: package.json devDependencies changed "ts-morph": "^26.0.0" → "^28.0.0".
- Do not introduce unrelated changes beyond bumping ts-morph — Met
- Evidence: The diff shows only the single-line version bump in package.json.
Documentation impact
- If the project documents required TypeScript versions or setup steps, update those to reflect TS 6 once peerDependencies is updated. Otherwise, no additional docs changes are needed for this specific version bump.
REQUEST_CHANGES
This PR introduces a dependency mismatch that can lead to toolchain breakage. Please align peerDependencies.typescript with ts-morph 28’s TypeScript 6 requirement (or keep ts-morph on a TS 5-compatible version) before merging.
9c99511 to
28700f2
Compare
There was a problem hiding this comment.
Independent adversarial review (Chinese-wall)
Reviewer: minsky-reviewer[bot] via openai:gpt-5
Tier: unknown
This dependency bump introduces a concrete incompatibility: ts-morph 28 targets TypeScript 6, but package.json still declares a peerDependency on typescript ^5.0.0. That will cause peer resolution issues and likely break dev tooling that uses ts-morph. Please align the TypeScript version (bump the peer to ^6 or keep ts-morph on a TS 5-compatible version). Additionally, update the Bun lockfile to reflect the new resolution and verify tsconfig under TS 6 semantics. The change is otherwise minimal and confined to the intended bump.
Findings
- [BLOCKING] package.json:90 — peerDependencies.typescript remains ^5.0.0 while devDependency ts-morph is bumped to ^28.0.0 (requires TypeScript 6)
The PR updates devDependencies.ts-morph to "^28.0.0" (see package.json devDependencies), but peerDependencies.typescript is still declared as "^5.0.0". Per the ts-morph 28.0.0 release notes in this PR, 28.x is a breaking release aligned to TypeScript 6.0 APIs. This mismatch will: - Trigger peer resolution errors/warnings on strict package managers (pnpm, Yarn Berry) when installing due to an incompatible TypeScript peer.
- Risk runtime/tooling failures in any dev scripts using ts-morph, because ts-morph 28 expects the TS 6 compiler API surface.
Required action: Align the TypeScript version with ts-morph 28. Either bump peerDependencies.typescript to a TS 6-compatible range (for example, "^6.0.0") and verify CI/tooling, or keep ts-morph at the last TS 5-compatible version if you must retain a TS 5 peer for consumers. Document the decision in the PR description if you intend dual support and how it’s enforced.
- [NON-BLOCKING] bun.lock:1 — Lockfile likely outdated relative to package.json bump
This repo commits a Bun lockfile (bun.lock). The diff only updates package.json to bump ts-morph, but bun.lock is not in the diff. If dependency resolution is locked, CI and contributors may not pick up the new ts-morph without updating the lockfile. Suggestion: runbun installand commit the updated bun.lock to keep installs reproducible. - [NON-BLOCKING] tsconfig.json:12 — TS 6 upgrade implied by ts-morph 28 may require tsconfig validation (verbatimModuleSyntax, decorators)
Given ts-morph 28 targets TypeScript 6, verify tsconfig under TS 6 semantics: - verbatimModuleSyntax is currently false; TS 6 tightened module emit semantics and defaults—double-check bundler mode behavior.
- experimentalDecorators and emitDecoratorMetadata remain legacy; TS 6 has updated decorator semantics—ensure usage aligns or add
"useDefineForClassFields"/decorators config as needed. - typeRoots/types should still resolve in bundler mode under TS 6.
This is advisory—once peerDependencies.typescript is bumped to ^6, run typecheck/build in CI and adjust config if necessary.
Spec verification
| Criterion | Status | Evidence |
|---|---|---|
| Bump ts-morph from 26.0.0 to 28.0.0 | Met | package.json devDependencies: "ts-morph": "^26.0.0" → "^28.0.0" (package.json lines ~77-96). |
| Do not introduce unrelated changes beyond bumping ts-morph | Met | Diff shows only a single-line change in package.json under devDependencies. No other files modified in this PR. |
28700f2 to
fa573da
Compare
There was a problem hiding this comment.
Independent adversarial review (Chinese-wall)
Reviewer: minsky-reviewer[bot] via openai:gpt-5
Tier: unknown
This PR cleanly bumps ts-morph to ^28.0.0, but it introduces a toolchain incompatibility: peerDependencies.typescript remains ^5.0.0 while ts-morph 28 targets TypeScript 6. This will cause peer resolution issues and potential runtime failures in dev tooling. Additionally, the committed Bun lockfile was not updated, reducing install reproducibility. After aligning the TypeScript peer to a TS 6–compatible range, please validate tsconfig and CI for TS 6 semantics. Requesting changes to fix the TypeScript peer mismatch (and ideally update the lockfile) before merge.
Findings
-
[BLOCKING] package.json:1 —
peerDependencies.typescriptremains^5.0.0whiledevDependencies.ts-morphis bumped to^28.0.0(ts-morph 28 requires TypeScript 6)
The diff updatesdevDependencies.ts-morphto^28.0.0(seepackage.jsonunderdevDependencies), butpeerDependencies.typescriptis still declared as"^5.0.0"(seepackage.jsonunderpeerDependencies). Per the release notes in this PR, ts-morph 28 is a breaking release aligned to TypeScript 6.0 APIs. This mismatch will: -
Cause peer resolution errors/warnings in strict package managers (pnpm, Yarn Berry) due to an incompatible TypeScript peer.
-
Risk runtime/tooling failures for any scripts using ts-morph because ts-morph 28 expects the TS 6 compiler API surface.
Required action: Align the TypeScript version with ts-morph 28. Either bump peerDependencies.typescript to a TS 6–compatible range (for example, ^6.0.0) and verify CI/tooling, or keep ts-morph pinned to the last TS 5–compatible version if you must retain a TS 5 peer for consumers. Document the decision if dual support is intended and how it’s enforced.
- [NON-BLOCKING] bun.lock:1 — Lockfile not updated alongside
package.jsonbump
This repository commits a Bun lockfile (bun.lock), but the diff only updatespackage.jsonto bumpts-morphand does not include changes tobun.lock. Without updating the lockfile, CI and contributors may not resolve tots-morph@^28.0.0consistently, undermining reproducibility.
Suggestion: Run bun install and commit the updated bun.lock so the dependency graph reflects the new version.
-
[NON-BLOCKING] tsconfig.json:1 — TS 6 implications likely require config/toolchain validation (after aligning peer
typescript)
Givents-morph@^28targets TypeScript 6, oncepeerDependencies.typescriptis updated to a TS 6–compatible range, please validate the TS config and toolchain: -
verbatimModuleSyntaxis currentlyfalse. TS 6 tightened module emit semantics; verify bundler mode behavior and consider enabling verbatim syntax if appropriate. -
Legacy decorators:
experimentalDecoratorsandemitDecoratorMetadataare enabled; TS 6 has updated decorators semantics—ensure this matches project usage or adjust flags/documentation accordingly. -
typeRoots/typesandmoduleResolution: "bundler"continue to behave as expected in TS 6.
This is advisory, but catching config/semantics shifts early will avoid CI/runtime surprises after the TS 6 alignment.
Spec verification
| Criterion | Status | Evidence |
|---|---|---|
| Bump ts-morph from 26.0.0 to 28.0.0 | Met | package.json devDependencies shows "ts-morph": "^28.0.0" (was ^26.0.0). See package.json: devDependencies. |
| Do not introduce unrelated changes beyond bumping ts-morph | Met | The diff shows only the single-line change in package.json under devDependencies for ts-morph. No other files were modified in this PR. |
fa573da to
3b94c1f
Compare
There was a problem hiding this comment.
Independent adversarial review (Chinese-wall)
Reviewer: minsky-reviewer[bot] via openai:gpt-5
Tier: unknown
The prior blocking issue remains: package.json still declares peerDependencies.typescript as ^5.0.0 while devDependencies.ts-morph is bumped to ^28.0.0, which aligns with TypeScript 6 and can cause install/runtime breakage. Please update the TypeScript peer range to include 6 (or defer the ts-morph bump) before merging. Also, consider updating bun.lock to reflect the new version and validate tsconfig/toolchain under TS 6, though these are non-blocking. Once the TypeScript peer is aligned, this PR should be safe to proceed.
Findings
-
[BLOCKING] package.json:1 —
peerDependencies.typescriptremains^5.0.0whiledevDependencies.ts-morphis bumped to^28.0.0(ts-morph 28 requires TypeScript 6)
The PR updatesdevDependencies.ts-morphto^28.0.0(seepackage.jsonunderdevDependencies), butpeerDependencies.typescriptis still declared as"^5.0.0"(seepackage.jsonunderpeerDependencies). Per the release notes included in this PR, ts-morph 28 is a breaking release aligned to TypeScript 6.0 APIs. This mismatch will: -
Cause peer resolution errors/warnings in strict package managers (pnpm, Yarn Berry) due to an incompatible TypeScript peer.
-
Risk runtime/tooling failures for any scripts using ts-morph because ts-morph 28 expects the TS 6 compiler API surface.
Required action: Align the TypeScript version with ts-morph 28. Either bump peerDependencies.typescript to a TS 6–compatible range (for example, ^6.0.0) and verify CI/tooling, or keep ts-morph pinned to the last TS 5–compatible version if you must retain a TS 5 peer for consumers. Document the decision if dual support is intended and how it’s enforced.
- [NON-BLOCKING] bun.lock:1 — Lockfile likely not updated alongside
package.jsonbump
This repo commits a Bun lockfile (bun.lock), but the PR only updatespackage.jsonto bumpts-morphand does not include a corresponding change tobun.lock. Without updating the lockfile, CI and contributors may not resolve tots-morph@^28.0.0consistently, undermining reproducibility.
Suggestion: Run bun install and commit the updated bun.lock so the dependency graph reflects the new version.
-
[NON-BLOCKING] tsconfig.json:1 — TS 6 upgrade implied by
ts-morph@^28likely requires tsconfig/toolchain validation
Givents-morph@^28targets TypeScript 6, oncepeerDependencies.typescriptis updated to a TS 6–compatible range, please validate the TS config and toolchain: -
verbatimModuleSyntaxis currentlyfalse. TS 6 tightened module emit semantics; verify bundler mode behavior and consider enabling verbatim syntax if appropriate for your build. -
Legacy decorators:
experimentalDecoratorsandemitDecoratorMetadataare enabled; TS 6 has updated decorators semantics—ensure this matches project usage or adjust flags/documentation accordingly.
Advisory only: run bun run typecheck and CI after bumping the TS peer to catch any config/semantics shifts.
Spec verification
| Criterion | Status | Evidence |
|---|---|---|
| Bump ts-morph from 26.0.0 to 28.0.0 | Met | package.json devDependencies shows "ts-morph": "^28.0.0" (was ^26.0.0). See package.json under devDependencies. |
| Do not introduce unrelated changes beyond bumping ts-morph | Met | The diff shows only the single-line change in package.json under devDependencies for ts-morph. No other files were modified by this PR. |
3b94c1f to
ca4e040
Compare
There was a problem hiding this comment.
Independent adversarial review (Chinese-wall)
Reviewer: minsky-reviewer[bot] via openai:gpt-5
Tier: unknown
The prior BLOCKING issue remains: peerDependencies.typescript is still ^5.0.0 while devDependencies.ts-morph is bumped to ^28.0.0, which targets TypeScript 6. This mismatch can cause install-time peer conflicts and runtime/tooling failures. Please align the TypeScript peer to a TS 6–compatible range or keep ts-morph on a TS 5–compatible version. Additionally, update the Bun lockfile and verify tsconfig/toolchain under TS 6; these are advisory. Once the TypeScript peer is corrected, this PR should be safe to merge.
Findings
-
[BLOCKING] package.json:1 —
peerDependencies.typescriptremains^5.0.0whiledevDependencies.ts-morphis bumped to^28.0.0(ts-morph 28 aligns with TypeScript 6)
The PR upgradesdevDependencies.ts-morphto^28.0.0, butpeerDependencies.typescriptis still declared as"^5.0.0"(seepackage.jsonunderpeerDependencies). Per the release notes included in this PR,ts-morph@28is a breaking release aligned to TypeScript 6.0 APIs. This mismatch will: -
Cause peer resolution errors/warnings in strict package managers (pnpm, Yarn Berry) due to an incompatible TypeScript peer.
-
Risk runtime/tooling failures for any scripts using ts-morph because ts-morph 28 expects the TS 6 compiler API surface.
Required action: Align the TypeScript version with ts-morph 28. Either bump peerDependencies.typescript to a TS 6–compatible range (for example, ^6.0.0) and verify CI/tooling, or keep ts-morph pinned to the last TS 5–compatible version if you must retain a TS 5 peer for consumers. Document the decision if dual support is intended and how it’s enforced.
- [NON-BLOCKING] bun.lock:1 — Lockfile not updated alongside
package.jsonbump
This repository commits a Bun lockfile (bun.lock), but the PR only updatespackage.jsonto bumpts-morphand does not include a corresponding change tobun.lock. Without updating the lockfile, CI and contributors may not resolve tots-morph@^28.0.0consistently, undermining reproducibility.
Suggestion: Run bun install and commit the updated bun.lock so the dependency graph reflects the new version.
-
[NON-BLOCKING] tsconfig.json:1 — TS 6 implications likely require tsconfig/toolchain validation (after aligning
peerDependencies.typescript)
Givents-morph@^28targets TypeScript 6, oncepeerDependencies.typescriptis updated to a TS 6–compatible range, please validate the TS config and toolchain: -
verbatimModuleSyntaxis currentlyfalse. TS 6 tightened module emit semantics; verify bundler mode behavior and consider enabling verbatim syntax if appropriate for your build. -
Legacy decorators:
experimentalDecoratorsandemitDecoratorMetadataare enabled; TS 6 has updated decorators semantics—ensure this matches project usage or adjust flags/documentation accordingly.
Advisory only: run bun run typecheck and CI after bumping the TS peer to catch any config/semantics shifts.
Spec verification
| Criterion | Status | Evidence |
|---|---|---|
| Bump ts-morph from 26.0.0 to 28.0.0 | Met | package.json devDependencies shows "ts-morph": "^28.0.0" (was ^26.0.0). See package.json under devDependencies. |
| Do not introduce unrelated changes beyond bumping ts-morph | Met | The diff shows only the single-line change in package.json under devDependencies for ts-morph. No other files were modified by this PR. |
ca4e040 to
db68e28
Compare
There was a problem hiding this comment.
Independent adversarial review (Chinese-wall)
Reviewer: minsky-reviewer[bot] via openai:gpt-5
Tier: unknown
The prior blocking issue remains: package.json still declares peerDependencies.typescript as 5.8.3 while devDependencies.ts-morph is bumped to ^28.0.0. Given ts-morph 28 aligns with TypeScript 6, this mismatch will cause peer resolution errors and likely runtime/tooling breakage. Please align the TypeScript peer to a TS 6–compatible range (or keep ts-morph on the last TS 5–compatible version). Additionally, the Bun lockfile was not updated; consider running bun install and committing the updated bun.lock for reproducibility. Once the TypeScript peer is corrected, this PR should be ready to merge.
Findings
- [BLOCKING] package.json:1 —
peerDependencies.typescriptis pinned to5.8.3whiledevDependencies.ts-morphis^28.0.0(ts-morph 28 aligns with TypeScript 6)
This PR upgradesdevDependencies.ts-morphto^28.0.0, butpeerDependencies.typescriptis declared as"5.8.3"inpackage.json(seepackage.json: peerDependencies). Per the release notes included in this PR,ts-morph@28is a breaking release aligned to TypeScript 6.0 APIs.
Impact:
- Package managers with strict peer resolution (pnpm, Yarn Berry) will warn/error due to the incompatible TypeScript peer.
- Any scripts/tooling that invoke
ts-morphwill likely break at runtime under TS 5 becausets-morph@28expects TS 6 compiler API surface.
Required action:
- Align the TypeScript version with
ts-morph@28. BumppeerDependencies.typescriptto a TS 6–compatible range (for example,^6.0.0), and verify CI/tooling under TS 6; or keepts-morphpinned to the last TS 5–compatible version if you must retain a TS 5 peer. If dual support is intended, document and enforce it explicitly (e.g., via conditional tooling or separate branches). - [NON-BLOCKING] bun.lock:1 — Lockfile not updated alongside
package.jsonbump
This repository commits a Bun lockfile (bun.lock), but the PR only updatespackage.jsonto bumpts-morphand does not include a corresponding change tobun.lock. Without updating the lockfile, CI and contributors may not resolve tots-morph@^28.0.0consistently, undermining reproducibility.
Suggestion: Run bun install and commit the updated bun.lock so the dependency graph reflects the new version.
Spec verification
| Criterion | Status | Evidence |
|---|---|---|
| Bump ts-morph from 26.0.0 to 28.0.0 | Met | package.json devDependencies shows "ts-morph": "^28.0.0" (was ^26.0.0). See package.json under devDependencies. |
| Do not introduce unrelated changes beyond bumping ts-morph | Met | The diff shows only the single-line change in package.json under devDependencies for ts-morph. No other files were modified by this PR. |
db68e28 to
f25930d
Compare
There was a problem hiding this comment.
Independent adversarial review (Chinese-wall)
Reviewer: minsky-reviewer[bot] via openai:gpt-5
Tier: unknown
The prior blocking issue remains: peerDependencies.typescript is still pinned to TypeScript 5 (5.8.3) while devDependencies.ts-morph is bumped to ^28.0.0, which aligns with TypeScript 6. This mismatch will cause peer resolution issues and likely runtime breakage in tooling using ts-morph. Please align the TypeScript peer to a TS 6–compatible range (or keep ts-morph on the last TS 5–compatible release).
Non-blocking notes: update the committed Bun lockfile and validate tsconfig/tooling once the TypeScript version is aligned. Once the peer dependency is corrected, this PR should be safe to merge.
Findings
- [BLOCKING] package.json:1 —
peerDependencies.typescriptremains on TypeScript 5 whiledevDependencies.ts-morphis bumped to ^28 (ts-morph 28 aligns with TypeScript 6)
The PR updatesdevDependencies.ts-morphto^28.0.0, butpeerDependencies.typescriptis declared as"5.8.3"(seepackage.json). Per the release notes in this PR,ts-morph@28is a breaking release aligned to TypeScript 6.0 APIs.
Impact:
- Strict package managers (pnpm, Yarn Berry) will warn/error due to the incompatible TypeScript peer.
- Any scripts/tooling that invoke
ts-morphare likely to break at runtime under TS 5 becausets-morph@28expects the TS 6 compiler API surface.
Required action:
- Align the TypeScript version with
ts-morph@28. BumppeerDependencies.typescriptto a TS 6–compatible range (for example,^6.0.0), and verify CI/tooling under TS 6; or keepts-morphpinned to the last TS 5–compatible version if you must retain a TS 5 peer. If dual support is intended, document and enforce it explicitly. - [NON-BLOCKING] bun.lock:1 — Lockfile not updated alongside
package.jsonbump
This repository commits a Bun lockfile (bun.lock), but the PR only updatespackage.jsonto bumpts-morphand does not include a corresponding change tobun.lock. Without updating the lockfile, CI and contributors may not resolve tots-morph@^28.0.0consistently, undermining reproducibility.
Suggestion: Run bun install and commit the updated bun.lock so the dependency graph reflects the new version.
-
[NON-BLOCKING] tsconfig.json:1 — TS 6 implications likely require tsconfig/toolchain validation once
peerDependencies.typescriptis updated
Givents-morph@^28targets TypeScript 6, after aligningpeerDependencies.typescriptto a TS 6–compatible range, please validate the TS config and toolchain: -
verbatimModuleSyntaxis currentlyfalse. TS 6 tightened module emit semantics; verify bundler mode behavior and consider enabling verbatim syntax if appropriate. -
Legacy decorators:
experimentalDecoratorsandemitDecoratorMetadataare enabled; TS 6 has updated decorators semantics—ensure this matches project usage or adjust flags/documentation accordingly.
Advisory only: run bun run typecheck and CI after bumping the TS peer to catch any config/semantics shifts.
Spec verification
| Criterion | Status | Evidence |
|---|---|---|
| Bump ts-morph from 26.0.0 to 28.0.0 | Met | package.json devDependencies shows "ts-morph": "^28.0.0" (was ^26.0.0). See package.json under devDependencies. |
| Do not introduce unrelated changes beyond bumping ts-morph | Met | The diff shows only the single-line change in package.json under devDependencies for ts-morph. No other files were modified by this PR. |
f25930d to
45c277e
Compare
There was a problem hiding this comment.
Independent adversarial review (Chinese-wall)
Reviewer: minsky-reviewer[bot] via openai:gpt-5
Tier: unknown
The prior blocking issue remains: peerDependencies.typescript is still set to a TypeScript 5 version (5.8.3) while devDependencies.ts-morph is bumped to ^28.0.0, which aligns with TypeScript 6. This mismatch will cause peer resolution errors on strict package managers and likely runtime/tooling failures. Please bump the TypeScript peer to a TS 6–compatible range or keep ts-morph on the last TS 5–compatible version. Additionally, consider updating the Bun lockfile and validating tsconfig/toolchain under TS 6 once aligned. Verdict: request changes.
Findings
- [BLOCKING] package.json:1 —
peerDependencies.typescriptremains on TypeScript 5 whiledevDependencies.ts-morphis bumped to ^28 (ts-morph 28 aligns with TypeScript 6)
This PR upgradesdevDependencies.ts-morphto^28.0.0, butpeerDependencies.typescriptis declared as"5.8.3"(seepackage.json: peerDependencies). Per the release notes included in this PR,ts-morph@28is a breaking release aligned to TypeScript 6.0 APIs.
Impact:
- Strict package managers (pnpm, Yarn Berry) will warn/error due to the incompatible TypeScript peer.
- Any scripts/tooling that invoke
ts-morphare likely to break at runtime under TS 5 becausets-morph@28expects the TS 6 compiler API surface.
Required action:
- Align the TypeScript version with
ts-morph@28. BumppeerDependencies.typescriptto a TS 6–compatible range (for example,^6.0.0), and verify CI/tooling under TS 6; or keepts-morphpinned to the last TS 5–compatible version if you must retain a TS 5 peer. If dual support is intended, document and enforce it explicitly. - [NON-BLOCKING] bun.lock:1 — Lockfile not updated alongside
package.jsonbump
This repository commits a Bun lockfile (bun.lock), but the PR only updatespackage.jsonto bumpts-morphand does not include a corresponding change tobun.lock. Without updating the lockfile, CI and contributors may not resolve tots-morph@^28.0.0consistently, undermining reproducibility.
Suggestion: Run bun install and commit the updated bun.lock so the dependency graph reflects the new version.
-
[NON-BLOCKING] tsconfig.json:1 — TS 6 implications likely require tsconfig/toolchain validation once
peerDependencies.typescriptis updated
Givents-morph@^28targets TypeScript 6, after aligningpeerDependencies.typescriptto a TS 6–compatible range, please validate the TS config and toolchain: -
verbatimModuleSyntaxis currentlyfalse. TS 6 tightened module emit semantics; verify bundler mode behavior and consider enabling verbatim syntax if appropriate. -
Legacy decorators:
experimentalDecoratorsandemitDecoratorMetadataare enabled; TS 6 has updated decorators semantics—ensure this matches project usage or adjust flags/documentation accordingly.
Advisory only: run bun run typecheck and CI after bumping the TS peer to catch any config/semantics shifts.
Spec verification
| Criterion | Status | Evidence |
|---|---|---|
| Bump ts-morph from 26.0.0 to 28.0.0 | Met | package.json devDependencies shows "ts-morph": "^28.0.0" (was ^26.0.0). See package.json: devDependencies. |
| Do not introduce unrelated changes beyond bumping ts-morph | Met | Diff shows only a single-line change in package.json under devDependencies for ts-morph. No other files were modified in this PR. |
45c277e to
23b8150
Compare
There was a problem hiding this comment.
Independent adversarial review (Chinese-wall)
Reviewer: minsky-reviewer[bot] via openai:gpt-5
Tier: unknown
The prior blocking issue remains: peerDependencies.typescript is still on TypeScript 5 ("5.8.3") while devDependencies.ts-morph is bumped to ^28.0.0, which targets TypeScript 6. This mismatch will cause peer resolution conflicts and likely break tooling using ts-morph. Please align the TypeScript peer to a TS 6–compatible range or keep ts-morph on a TS 5–compatible version. Additionally, the Bun lockfile was not updated alongside package.json; updating it would ensure reproducible installs. Once the TypeScript peer is aligned, this PR should be good to merge.
Findings
- [BLOCKING] package.json:1 —
peerDependencies.typescriptremains on TypeScript 5 whiledevDependencies.ts-morphis bumped to ^28 (ts-morph 28 aligns with TypeScript 6)
This PR upgradesdevDependencies.ts-morphto^28.0.0(seepackage.json: devDependencies), butpeerDependencies.typescriptis declared as"5.8.3"(seepackage.json: peerDependencies). Per the release notes included in this PR,ts-morph@28is a breaking release aligned to TypeScript 6.0 APIs.
Impact:
- Strict package managers (pnpm, Yarn Berry) will warn/error due to the incompatible TypeScript peer.
- Any scripts/tooling that invoke
ts-morphare likely to break at runtime under TS 5 becausets-morph@28expects the TS 6 compiler API surface.
Required action:
- Align the TypeScript version with
ts-morph@28. BumppeerDependencies.typescriptto a TS 6–compatible range (for example,^6.0.0), and verify CI/tooling under TS 6; or keepts-morphpinned to the last TS 5–compatible version if you must retain a TS 5 peer. If dual support is intended, document and enforce it explicitly. - [NON-BLOCKING] bun.lock:1 — Lockfile not updated alongside
package.jsonbump
This repository commits a Bun lockfile (bun.lock), but the PR only updatespackage.jsonto bumpts-morphand does not include a corresponding change tobun.lock. Without updating the lockfile, CI and contributors may not resolve tots-morph@^28.0.0consistently, which undermines reproducibility.
Suggestion: Run bun install and commit the updated bun.lock so the dependency graph reflects the new version.
Spec verification
| Criterion | Status | Evidence |
|---|---|---|
| Bump ts-morph from 26.0.0 to 28.0.0 | Met | package.json devDependencies shows "ts-morph": "^28.0.0" (was ^26.0.0). See package.json under devDependencies lines ~62-86. |
| Do not introduce unrelated changes beyond bumping ts-morph | Met | The diff shows only a single-line change in package.json under devDependencies for ts-morph. No other files were modified in this PR’s diff snippet. |
23b8150 to
85bd212
Compare
There was a problem hiding this comment.
Independent adversarial review (Chinese-wall)
Reviewer: minsky-reviewer[bot] via openai:gpt-5
Tier: unknown
The previous blocking issue remains: package.json bumps ts-morph to ^28.0.0, which aligns with TypeScript 6, but peerDependencies.typescript is still pinned to 5.8.3. This mismatch can cause peer resolution errors and tooling/runtime breakage for any scripts using ts-morph. Please align the TypeScript peer to a TS 6–compatible range or keep ts-morph on the last TS 5–compatible version. Additionally, the Bun lockfile was not updated alongside the version bump; updating and committing bun.lock would improve reproducibility. Once the TypeScript peer is aligned (or ts-morph reverted accordingly) and the lockfile is refreshed, this should be ready to merge.
Findings
- [BLOCKING] package.json:1 —
peerDependencies.typescriptremains on TypeScript 5 whiledevDependencies.ts-morphis bumped to ^28 (ts-morph 28 aligns with TypeScript 6)
This PR upgradesdevDependencies.ts-morphto^28.0.0, butpeerDependencies.typescriptis still declared as"5.8.3"inpackage.json.
Per the release notes included in this PR, ts-morph@28 is a breaking release aligned to TypeScript 6.0 APIs. This mismatch will:
- Trigger peer resolution warnings/errors in strict package managers (pnpm, Yarn Berry) due to an incompatible TypeScript peer.
- Risk runtime/tooling failures for any scripts or tooling that use
ts-morph, becausets-morph@28expects the TS 6 compiler API surface when operating on sources.
Required action:
- Align the TypeScript version with
ts-morph@28. BumppeerDependencies.typescriptto a TS 6–compatible range (for example,^6.0.0or>=6 <7), and verify CI/tooling under TS 6; or keepts-morphpinned to the last TS 5–compatible version if you must retain a TS 5 peer. If dual support is intended, document and enforce it explicitly.
Evidence:
package.jsondevDependencies.ts-morph:^28.0.0package.jsonpeerDependencies.typescript:"5.8.3"- [NON-BLOCKING] bun.lock:1 — Lockfile not updated alongside
package.jsonbump may reduce reproducibility
The repository commits a Bun lockfile (bun.lock), but the PR only updatespackage.jsonto bumpts-morphand does not include a corresponding change tobun.lock. Without updating the lockfile, CI and contributors may not resolve tots-morph@^28.0.0consistently, which undermines reproducibility.
Suggestion: Run bun install and commit the updated bun.lock so the lockfile reflects the new dependency graph.
85bd212 to
ff501c0
Compare
There was a problem hiding this comment.
Independent adversarial review (Chinese-wall)
Reviewer: minsky-reviewer[bot] via openai:gpt-5
Tier: unknown
The prior blocking issue remains: peerDependencies.typescript is still pinned to TypeScript 5 while devDependencies.ts-morph is upgraded to ^28, which targets TypeScript 6. This mismatch will cause peer resolution problems and potential runtime/tooling breakage with ts-morph relying on TS 6 APIs. Please align the TypeScript peer to a TS 6–compatible range (or keep ts-morph on the last TS 5–compatible version). Additionally, consider updating bun.lock to reflect the new dependency for reproducible installs. Once the TypeScript peer is corrected, this PR should be safe to merge.
Findings
-
[BLOCKING] package.json:1 —
peerDependencies.typescriptremains on TypeScript 5 whiledevDependencies.ts-morphis ^28 (ts-morph 28 aligns with TypeScript 6)
The PR upgradesdevDependencies.ts-morphto^28.0.0, butpeerDependencies.typescriptis still declared as ` -
[BLOCKING] package.json:1 — TypeScript peer dependency is incompatible with
ts-morph@^28(ts-morph 28 targets TS 6)
This PR bumpsdevDependencies.ts-morphto^28.0.0, butpeerDependencies.typescriptremains"5.8.3"(TypeScript 5). Per the release notes linked in this PR,ts-morph@28is a breaking release aligned to TypeScript 6.0 compiler APIs. Keeping a TS 5 peer will: -
Cause peer resolution warnings/errors on strict package managers (pnpm, Yarn Berry).
-
Risk runtime/tooling failures in any scripts using
ts-morph, sincets-morph@28expects the TS 6 API surface.
Required action:
- Align the TypeScript version with
ts-morph@28: bumppeerDependencies.typescriptto a TS 6–compatible range (for example,^6.0.0or>=6 <7), and ensure CI/tooling use TS 6; or keepts-morphpinned to the last TS 5–compatible version if you must retain a TS 5 peer. If dual support is intended, document and enforce it explicitly.
Evidence:
package.jsondevDependencies.ts-morph:^28.0.0.package.jsonpeerDependencies.typescript:"5.8.3". Seepackage.jsonnear thepeerDependenciesblock.- [NON-BLOCKING] bun.lock:1 — Lockfile not updated alongside
package.jsonbump may reduce reproducibility
The repository commits a Bun lockfile (bun.lock), but the diff only updatespackage.jsonto bumpts-morphand does not include a corresponding change tobun.lock. Without updating the lockfile, CI and contributors may not actually installts-morph@^28.0.0, undermining reproducibility.
Suggestion: Run bun install and commit the updated bun.lock so the dependency graph reflects the new version.
ff501c0 to
1a4d171
Compare
There was a problem hiding this comment.
Independent adversarial review (Chinese-wall)
Reviewer: minsky-reviewer[bot] via openai:gpt-5
Tier: 3
The prior blocking issue remains: peerDependencies.typescript is still pinned to TypeScript 5 ("5.8.3") while devDependencies.ts-morph has been upgraded to ^28.0.0, which targets TypeScript 6. This mismatch can cause peer resolution errors and runtime/tooling breakage. Please align the TypeScript peer to a TS 6–compatible range or keep ts-morph on the last TS 5–compatible version. Additionally, consider updating bun.lock so installs consistently pick up the new version. Once the TS peer is aligned, this PR should be good to merge.
Findings
-
[BLOCKING] package.json:1 — TypeScript peer dependency is incompatible with
ts-morph@^28(ts-morph 28 targets TS 6)
devDependencies.ts-morphis bumped to^28.0.0, butpeerDependencies.typescriptremains"5.8.3"(TypeScript 5). Per the release notes linked in this PR,ts-morph@28is a breaking release aligned to TypeScript 6.0 compiler APIs. Keeping a TS 5 peer will: -
Cause peer resolution warnings/errors on strict package managers (pnpm, Yarn Berry).
-
Risk runtime/tooling failures in any scripts using
ts-morph, sincets-morph@28expects the TS 6 API surface.
Required action: Align the TypeScript version with ts-morph@28: bump peerDependencies.typescript to a TS 6–compatible range (for example, ^6.0.0 or >=6 <7) and ensure CI/tooling use TS 6; or keep ts-morph pinned to the last TS 5–compatible version if you must retain a TS 5 peer. Evidence: see package.json — devDependencies.ts-morph: ^28.0.0 and peerDependencies.typescript: "5.8.3".
- [NON-BLOCKING] bun.lock:1 — Lockfile not updated alongside
package.jsonbump may reduce reproducibility
This repository commits a Bun lockfile (bun.lock), but the PR only updatespackage.jsonto bumpts-morphand does not include a corresponding change tobun.lock. Without updating the lockfile, CI and contributors may not actually installts-morph@^28.0.0, undermining reproducibility. Suggestion: runbun installand commit the updatedbun.lockso the dependency graph reflects the new version.
Spec verification
| Criterion | Status | Evidence |
|---|---|---|
| Bump ts-morph from 26.0.0 to 28.0.0 | Met | package.json devDependencies shows "ts-morph": "^28.0.0" (was ^26.0.0). See package.json under devDependencies lines ~60–86. |
| Do not introduce unrelated changes beyond bumping ts-morph | Met | The diff shows only a single-line change in package.json under devDependencies for ts-morph. No other files are modified in this PR. |
Bumps [ts-morph](https://github.com/dsherret/ts-morph) from 26.0.0 to 28.0.0. - [Release notes](https://github.com/dsherret/ts-morph/releases) - [Commits](dsherret/ts-morph@26.0.0...28.0.0) --- updated-dependencies: - dependency-name: ts-morph dependency-version: 28.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
1a4d171 to
864efb7
Compare
There was a problem hiding this comment.
Independent adversarial review (Chinese-wall)
Reviewer: minsky-reviewer[bot] via openai:gpt-5
Tier: 3
The prior blocking issue remains: package.json declares peerDependencies.typescript as 5.8.3 while devDependencies.ts-morph has been upgraded to ^28.0.0, which targets TypeScript 6. This mismatch will cause peer resolution issues and potential runtime/tooling failures. Please align the TypeScript peer to a TS 6–compatible range or hold ts-morph at the last TS 5–compatible version. Additionally, consider updating and committing bun.lock to reflect the new dependency resolution. Once the TS peer is aligned (or ts-morph version adjusted) and the lockfile is refreshed, this PR should be good to merge.
Findings
-
[BLOCKING] package.json:1 — TypeScript peer dependency is incompatible with
ts-morph@^28(ts-morph 28 targets TS 6)
devDependencies.ts-morphis bumped to^28.0.0, butpeerDependencies.typescriptremains"5.8.3"(TypeScript 5). Per the release notes linked in this PR,ts-morph@28is a breaking release aligned to TypeScript 6.0 compiler APIs. Keeping a TS 5 peer will: -
Cause peer resolution warnings/errors on strict package managers (pnpm, Yarn Berry).
-
Risk runtime/tooling failures in any scripts using
ts-morph, sincets-morph@28expects the TS 6 API surface.
Required action: Align the TypeScript version with ts-morph@28: bump peerDependencies.typescript to a TS 6–compatible range (for example, ^6.0.0 or >=6 <7) and ensure CI/tooling use TS 6; or keep ts-morph pinned to the last TS 5–compatible version if you must retain a TS 5 peer. Evidence: see package.json — devDependencies.ts-morph: ^28.0.0 and peerDependencies.typescript: "5.8.3".
- [NON-BLOCKING] bun.lock:1 — Lockfile not updated alongside
package.jsonbump may reduce reproducibility
This repository commits a Bun lockfile (bun.lock), but the PR only updatespackage.jsonto bumpts-morphand does not include a corresponding change tobun.lock. Without updating the lockfile, CI and contributors may not actually installts-morph@^28.0.0, undermining reproducibility.
Suggestion: run bun install and commit the updated bun.lock so the dependency graph reflects the new version.
Spec verification
| Criterion | Status | Evidence |
|---|---|---|
| Bump ts-morph from 26.0.0 to 28.0.0 | Met | package.json devDependencies.ts-morph: ^26.0.0 → ^28.0.0. See package.json lines ~62–86 showing "ts-morph": "^28.0.0". |
| Do not introduce unrelated changes beyond bumping ts-morph | Met | The diff shows only a single-line change in package.json under devDependencies for ts-morph. No other files are modified in the provided diff. Repo root lists bun.lock present but not changed in this PR. |
Bumps ts-morph from 26.0.0 to 28.0.0.
Release notes
Sourced from ts-morph's releases.
... (truncated)
Commits
c895bee28.0.0 (#1672)f731ab2docs: add logo (#1671)76ca64efeat: standaloneprintStructurefunction (#1670)0c57a18fix:InvalidOperationErrorinaddTypeArgument(#1663)d3f77b8feat(BREAKING): TypeScript 6.0 (#1669)0dd1adc27.0.2 (#1659)44d04c9chore: do not attempt npm publish when package already exists (#1658)923182dfix: browser support no longer working since #1628 in 26.0.0 due to missing b...2182f9927.0.0 (#1652)673161efeat: ability to add and remove the defer keyword in imports (#1651)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for ts-morph since your current version.