Conversation
|
⏭️ No files to mutate for |
|
⏭️ No files to mutate for |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 100% | 0/0 |
| 🟢 | Branches | 100% | 0/0 |
| 🟢 | Functions | 100% | 0/0 |
| 🟢 | Lines | 100% | 0/0 |
Test suite run success
1 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from 09bca13
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 99.88% (+0.23% 🔼) |
856/857 |
| 🟢 | Branches | 99.57% (+0.87% 🔼) |
232/233 |
| 🟢 | Functions | 98.1% | 207/211 |
| 🟢 | Lines | 99.88% (+0.24% 🔼) |
823/824 |
Test suite run success
442 tests passing in 25 suites.
Report generated by 🧪jest coverage report action from 09bca13
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 70.97% | 22/31 |
| 🔴 | Branches | 20% | 1/5 |
| 🟡 | Functions | 75% | 6/8 |
| 🟡 | Lines | 68.97% | 20/29 |
Test suite run success
4 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from 09bca13
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 67.51% | 160/237 |
| 🟢 | Branches | 80% | 60/75 |
| 🔴 | Functions | 57.14% | 20/35 |
| 🟡 | Lines | 67.52% | 158/234 |
Test suite run success
67 tests passing in 4 suites.
Report generated by 🧪jest coverage report action from 09bca13
|
⏭️ No files to mutate for |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 100% | 98/98 |
| 🟢 | Branches | 100% | 36/36 |
| 🟢 | Functions | 100% | 24/24 |
| 🟢 | Lines | 100% | 91/91 |
Test suite run success
66 tests passing in 5 suites.
Report generated by 🧪jest coverage report action from 09bca13
neSpecc
reviewed
Apr 14, 2026
Comment on lines
+349
to
+352
| blocksManager.move(1, 1); | ||
|
|
||
| expect(model.removeBlock).toHaveBeenCalledWith(USER_ID, 1); | ||
| expect(model.addBlock).toHaveBeenCalledWith(USER_ID, { name: 'b' }, 2); |
e11sy
reviewed
Apr 14, 2026
e11sy
reviewed
Apr 14, 2026
| * @param blocks - array of blocks to insert | ||
| * @param [index] - index to insert blocks at. If undefined, inserts at the end | ||
| */ | ||
| public insertMany(blocks: BlockNodeSerialized[], index: number = this.#model.length + 1): void { |
Member
There was a problem hiding this comment.
why +1, model indexing starts with 1?
Comment on lines
+28
to
+30
| '@typescript-eslint/unbound-method': 'off', | ||
| '@typescript-eslint/naming-convention': 'off', | ||
| 'n/no-unsupported-features/node-builtins': 'off', |
neSpecc
approved these changes
Apr 14, 2026
| // @todo: remove when we setup eslint to correctly handle the types | ||
| 'n/no-missing-import': 'off', | ||
| '@typescript-eslint/unbound-method': 'off', | ||
| '@typescript-eslint/naming-convention': 'off', |
Contributor
There was a problem hiding this comment.
why it is disabled for a whole project instead of tests-only?
e11sy
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.