Feature/group up#14
Open
edge-marge wants to merge 4 commits into
Open
Conversation
Closed
orcist
reviewed
May 21, 2026
Collaborator
orcist
left a comment
orcist
left a comment
There was a problem hiding this comment.
small naming change request
| ); | ||
| } | ||
|
|
||
| public void GetGroupMemberDetailsAsync( |
Collaborator
There was a problem hiding this comment.
could you simplify the method names? including the other new group methods.
Suggested change
| public void GetGroupMemberDetailsAsync( | |
| public void GetGroupMember( |
detail seems a little unnecessary, and there's no need to repeat async everywhere that's just a legacy pattern from the matchmaking SDK. All the methods are now async using the same pattern so mentioning it everywhere is a little redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.