Only ccache save/restore on main to improve our cache hit rate/TTLs#185
Open
bleggett wants to merge 1 commit into
Open
Only ccache save/restore on main to improve our cache hit rate/TTLs#185bleggett wants to merge 1 commit into
ccache save/restore on main to improve our cache hit rate/TTLs#185bleggett wants to merge 1 commit into
Conversation
bleggett
changed the title
ccache save/restore on main to improve our cache hit rate/TTLs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do not need to cache PR branch run ccache bundles, because branches can (and do) inherit
maincaches automatically, it is only the inverse that is disallowedAnd, caching ccache results from PR branches counts against the 10GB github limit, which eats into our overall ability to save
mainccache bundles.This is why we were losing ccache bundles in CI builds - the TTL wasn't expiring, we were hitting the 10GB limit, and losing our ccache when we didn't need to.