Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.rs/dmidecode/latest/dmidecode/
This captures all of the bytes, but does not fully decode as many into human-readable format as the binary does.
But it has the added benefit of working exactly the same way inside and outside of a container, and not requiring a host (or container) bin, or a custom impl, so on the whole I like it better as an option.
I looked at possibly just slurping raw bytes from
/sys/firmware/dmi/tables/in the the host namespace context, and then replaying the raw bytes from that against an OCI-localdmidecodebinary - butdmidecodehas some quirks that make that tricky, and that doesn't solve for running the nakededera-checkbinary outside of an OCI image - this does.Fixes part-of: #86