feat(dpr): able to update dpr by resize#1149
Open
Justin-ZS wants to merge 3 commits intoecomfe:masterfrom
Open
feat(dpr): able to update dpr by resize#1149Justin-ZS wants to merge 3 commits intoecomfe:masterfrom
Justin-ZS wants to merge 3 commits intoecomfe:masterfrom
Conversation
7 tasks
plainheart
reviewed
Jan 30, 2026
plainheart
reviewed
Jan 30, 2026
src/canvas/Painter.ts
Outdated
Collaborator
There was a problem hiding this comment.
I tend to completely replace the constant devicePixelRatio in favor of the new getDevicePixelRatio() function.
src/canvas/Layer.ts
Outdated
Collaborator
There was a problem hiding this comment.
Or just let the DPR fall back to 1 and only do it in zrender constructor?
https://github.com/Justin-ZS/zrender/blob/5a52347e793a2eeffcc9eaed5dd4538087755eac/src/zrender.ts#L92
Author
There was a problem hiding this comment.
I prefer to do it only in the Canvas Painter constructor.
Justin-ZS
commented
Feb 2, 2026
| // TODO sting? | ||
| height = opts.height as number; | ||
| } | ||
| this.dpr = opts.devicePixelRatio || 1; |
Author
There was a problem hiding this comment.
@plainheart
Since this.dpr has already been initialized before, I removed this line.
Please let me know if forcing 1 here was intentional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devicePixelRatioupdates through theresize()methodLayer.updateDpr()to keep canvas context dpr in syncFix
apache/echarts#21386
Usage
Changes
devicePixelRatioparameter toPainterBase.resize()interfaceLayer.updateDpr()methodPainter.resize()to trigger layer resize on dpr changedevicePixelRatiooption inZRender.resize()