Skip to content

Fix missing includes compiling with GNU 14.2.0#253

Closed
wdeconinck wants to merge 2 commits intodevelopfrom
fix/missing_includes
Closed

Fix missing includes compiling with GNU 14.2.0#253
wdeconinck wants to merge 2 commits intodevelopfrom
fix/missing_includes

Conversation

@wdeconinck
Copy link
Copy Markdown
Member

@wdeconinck wdeconinck commented Mar 26, 2026

Description

Compiling ifs-bundle "main" (commit 618ef84, dated 20.03.2026) on our HPC with arch "arch/ecmwf/hpc2020/gnu/14.2.0/hpcx-openmpi/2.18.1" is using multio v2.7.0.
This gave some compilation errors with missing includes for <algorithm> for use of std::find_if and std::remove_if.
I noticed these missing includes were not present in the develop either, so here goes.

FYI @towil1 , @ioanhadade . Was this not yet spotted before with any CI?

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/multio/pull-requests/PR-253

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.34%. Comparing base (0e50458) to head (36d90e1).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #253      +/-   ##
===========================================
- Coverage    56.34%   56.34%   -0.01%     
===========================================
  Files          321      321              
  Lines        21145    21146       +1     
  Branches      1680     1678       -2     
===========================================
  Hits         11915    11915              
- Misses        9230     9231       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ioanhadade
Copy link
Copy Markdown
Contributor

I have only really worked with gnu 15.2.0 so cant really say, cant remember if I have ever seen that error although looks very familiar

@wdeconinck wdeconinck requested a review from dsarmany March 26, 2026 14:38
@dsarmany
Copy link
Copy Markdown
Collaborator

Hey -- Thank you for reporting this @wdeconinck . This was fixed for 2.8.0. It just may not be obvious because the include was introduced slightly deeper in the datamod stack: 9c7bdd0 .

@wdeconinck
Copy link
Copy Markdown
Member Author

Okay fair enough. That wasn't obvious to me and I couldn't just use update multio without updating other packages.
N.B. in my opinion you should add the includes where they are used, so that when it gets removed in the deeper files it doesn't break again. Please close this if you want.

@ioanhadade
Copy link
Copy Markdown
Contributor

im hitting this in 50r3 with gnu 15.2.0, is it safe to version bump to 2.8.0?

@dsarmany
Copy link
Copy Markdown
Collaborator

im hitting this in 50r3 with gnu 15.2.0, is it safe to version bump to 2.8.0?

I would think so but you may have to update some other packages as well (eckit etc.) I will put this change into the hotfix 2.7.4 version just in case. Balthi had a PR for that already, which I can re-purpose: #241 .

I will close this as a duplicate and merge that one instead.

@dsarmany dsarmany closed this Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants