Fix missing includes compiling with GNU 14.2.0#253
Fix missing includes compiling with GNU 14.2.0#253wdeconinck wants to merge 2 commits intodevelopfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #253 +/- ##
===========================================
- Coverage 56.34% 56.34% -0.01%
===========================================
Files 321 321
Lines 21145 21146 +1
Branches 1680 1678 -2
===========================================
Hits 11915 11915
- Misses 9230 9231 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I have only really worked with gnu 15.2.0 so cant really say, cant remember if I have ever seen that error although looks very familiar |
|
Hey -- Thank you for reporting this @wdeconinck . This was fixed for 2.8.0. It just may not be obvious because the include was introduced slightly deeper in the datamod stack: 9c7bdd0 . |
|
Okay fair enough. That wasn't obvious to me and I couldn't just use update multio without updating other packages. |
|
im hitting this in 50r3 with gnu 15.2.0, is it safe to version bump to 2.8.0? |
I would think so but you may have to update some other packages as well (eckit etc.) I will put this change into the hotfix 2.7.4 version just in case. Balthi had a PR for that already, which I can re-purpose: #241 . I will close this as a duplicate and merge that one instead. |
Description
Compiling ifs-bundle "main" (commit 618ef84, dated 20.03.2026) on our HPC with arch "arch/ecmwf/hpc2020/gnu/14.2.0/hpcx-openmpi/2.18.1" is using multio v2.7.0.
This gave some compilation errors with missing includes for
<algorithm>for use ofstd::find_ifandstd::remove_if.I noticed these missing includes were not present in the develop either, so here goes.
FYI @towil1 , @ioanhadade . Was this not yet spotted before with any CI?
Contributor Declaration
By opening this pull request, I affirm the following:
🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/multio/pull-requests/PR-253