Open
Conversation
Oisin-M
force-pushed
the
feat/remove_station_mapping
branch
from
9da9b06 to
53ee89e
Compare
Oisin-M
force-pushed
the
feat/remove_station_mapping
branch
from
53ee89e to
e04092d
Compare
colonesej
approved these changes
Mar 30, 2026
Collaborator
colonesej
left a comment
colonesej
left a comment
There was a problem hiding this comment.
Thanks for tagging me @Oisin-M . The tests for the plotting part will come in the feature/split_plots_and_widget_interface branch. I can create a WIP PR for it already, but now with all these structural changes it may be better to wait and merge this one first.
| authors = [ | ||
| {name = "European Centre for Medium-Range Weather Forecasts (ECMWF)", email = "software.support@ecmwf.int"}, | ||
| ] | ||
| maintainers = [ |
Collaborator
There was a problem hiding this comment.
Can we replace this by a contributors list ? and I think we should all be there.
| "ipyleaflet", | ||
| "ipywidgets", | ||
| "earthkit-data>=0.18.2", | ||
| "earthkit-hydro>=1.2.0", |
Collaborator
There was a problem hiding this comment.
Can you also check the dependencies? I don't think we will need hydro and some of the "heavy" data dependencies here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the station-mapping functionality. Idea is that this should now belong in ecmwf/hydro-station-mapping to avoid conflating too many things here.
TODO:
Notes:
Contributor Declaration
By opening this pull request, I affirm the following: