Skip to content

pyfdb: Always use array size specified by user#261

Open
ChrisspyB wants to merge 3 commits intodevelopfrom
fix/pyfdb-array-size
Open

pyfdb: Always use array size specified by user#261
ChrisspyB wants to merge 3 commits intodevelopfrom
fix/pyfdb-array-size

Conversation

@ChrisspyB
Copy link
Copy Markdown
Member

@ChrisspyB ChrisspyB commented Apr 2, 2026

Description

It is currently not possible to read data from remoteFDB due to RemoteDataHandle.size() being NOTIMP. We should not have to call this function when a user specifies an array size.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/fdb/pull-requests/PR-261

This allows working around data handles that have NOTIMP .size methods
@ChrisspyB ChrisspyB requested a review from tbkr April 2, 2026 11:38
tbkr

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

@tbkr tbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, there are tests failing, though?

On second thought: this is breaking the shutil test case. We should double check whether this functionality is needed and come up with a solution for this.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.19%. Comparing base (62cc4bd) to head (2f6a24e).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #261   +/-   ##
========================================
  Coverage    71.19%   71.19%           
========================================
  Files          376      376           
  Lines        23762    23762           
  Branches      2478     2478           
========================================
  Hits         16918    16918           
  Misses        6844     6844           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants