Skip to content

Enable Node ACL based on ECF_PERMISSIONS ECFLOW-1960 #309

Draft
marcosbento wants to merge 1 commit intodevelopfrom
feature/node_acl
Draft

Enable Node ACL based on ECF_PERMISSIONS ECFLOW-1960 #309
marcosbento wants to merge 1 commit intodevelopfrom
feature/node_acl

Conversation

@marcosbento
Copy link
Copy Markdown
Collaborator

@marcosbento marcosbento commented Mar 27, 2026

Description

Enable Node ACL based on ECF_PERMISSION

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/ecflow/pull-requests/PR-309

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.31792% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.81%. Comparing base (b8b9e22) to head (1ef38e0).

Files with missing lines Patch % Lines
...ibs/server/src/ecflow/server/ServerEnvironment.cpp 51.11% 22 Missing ⚠️
libs/server/src/ecflow/server/HttpServer.cpp 23.80% 16 Missing ⚠️
libs/node/src/ecflow/node/permissions/Allowed.cpp 50.00% 7 Missing ⚠️
libs/node/src/ecflow/node/Alias.cpp 40.00% 3 Missing ⚠️
libs/node/src/ecflow/node/formatter/DefsWriter.hpp 97.43% 3 Missing ⚠️
libs/base/src/ecflow/base/stc/SSyncCmd.cpp 88.88% 2 Missing ⚠️
libs/core/src/ecflow/core/Identity.hpp 86.66% 2 Missing ⚠️
libs/node/src/ecflow/node/ExprParser.cpp 0.00% 2 Missing ⚠️
.../server/src/ecflow/server/AuthorisationService.cpp 90.90% 2 Missing ⚠️
Viewer/ecflowUI/src/VTriggerAttr.cpp 0.00% 1 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #309      +/-   ##
===========================================
+ Coverage    49.62%   49.81%   +0.18%     
===========================================
  Files         1237     1244       +7     
  Lines        97536    97957     +421     
  Branches     14828    14888      +60     
===========================================
+ Hits         48407    48800     +393     
- Misses       49129    49157      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants