ECC-2270: GRIB2: LC-GCR and WPMIP update#477
Conversation
|
The files contain duplicated code, which can be error-prone. To avoid this, we could move the shared changes into a separate file and use the include keyword to reuse them in multiple locations. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #477 +/- ##
========================================
Coverage 88.53% 88.53%
========================================
Files 850 850
Lines 63289 63289
Branches 11262 11262
========================================
Hits 56036 56036
Misses 7253 7253 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Also the existing 4 files are almost identical (except for the title) and would benefit from this approach: |
|
Hi there, I am not updating other files below as suggested as this is out of scope for this hotfix and it needs DGOV agreement on that too (how to call include files etc). |
Description
This pull request adds new GRIB2 product definition files for various re-analysis and test products, improving support for additional datasets. Each new file establishes standard parameter aliases to ensure consistency across the codebase.
To be merged to develop and cherry-picked into hotfix/2.47.1
Contributor Declaration
By opening this pull request, I affirm the following: