Skip to content

ECC-2270: GRIB2: LC-GCR and WPMIP update#477

Open
richard-mladek wants to merge 2 commits into
ecmwf:developfrom
richard-mladek:feature/DGOV-513_lcgcr
Open

ECC-2270: GRIB2: LC-GCR and WPMIP update#477
richard-mladek wants to merge 2 commits into
ecmwf:developfrom
richard-mladek:feature/DGOV-513_lcgcr

Conversation

@richard-mladek
Copy link
Copy Markdown
Contributor

@richard-mladek richard-mladek commented May 12, 2026

Description

This pull request adds new GRIB2 product definition files for various re-analysis and test products, improving support for additional datasets. Each new file establishes standard parameter aliases to ensure consistency across the codebase.

To be merged to develop and cherry-picked into hotfix/2.47.1

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@joobog
Copy link
Copy Markdown
Collaborator

joobog commented May 12, 2026

The files contain duplicated code, which can be error-prone. To avoid this, we could move the shared changes into a separate file and use the include keyword to reuse them in multiple locations.

@joobog joobog changed the title ECC-2270 ECC-2270: GRIB2: LC-GCR and WPMIP update May 12, 2026
@joobog joobog added the approved-for-ci Approved to run CI on ECMWF machines label May 12, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (3d119d8) to head (db36e29).
⚠️ Report is 12 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #477   +/-   ##
========================================
  Coverage    88.53%   88.53%           
========================================
  Files          850      850           
  Lines        63289    63289           
  Branches     11262    11262           
========================================
  Hits         56036    56036           
  Misses        7253     7253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shahramn
Copy link
Copy Markdown
Collaborator

The files contain duplicated code, which can be error-prone. To avoid this, we could move the shared changes into a separate file and use the include keyword to reuse them in multiple locations.

Also the existing 4 files are almost identical (except for the title) and would benefit from this approach:
products_0.def
products_1.def
products_2.def
products_3.def

@github-actions github-actions Bot removed the approved-for-ci Approved to run CI on ECMWF machines label May 14, 2026
@richard-mladek
Copy link
Copy Markdown
Contributor Author

Hi there,
I have just done the suggested updates for lcgcr and wpmip projects only:
products_14.def
products_15.def
products_16.def
products_17.def
Those updates allow showing correct main mars metadata using grib_ls -m which is important at this stage.
Further updates for coming synchronised release in June will follow (DGOV follow up needed for that).

I am not updating other files below as suggested as this is out of scope for this hotfix and it needs DGOV agreement on that too (how to call include files etc).
products_0.def
products_1.def
products_2.def
products_3.def

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants