ECC-1734: GRIB2: typeOfTimeIncrement=1 removes endStep and stepRange#447
Open
ECC-1734: GRIB2: typeOfTimeIncrement=1 removes endStep and stepRange#447
Conversation
…and stepRange, which is incorrect. We contain this undesirable behaviour to pre-mtg2 data only to keep backwards compatibility but have post-mtg2 interpreted correctly. Passes all ctests and regression tests.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #447 +/- ##
========================================
Coverage 88.53% 88.53%
========================================
Files 849 849
Lines 63097 63101 +4
Branches 11236 11238 +2
========================================
+ Hits 55862 55866 +4
Misses 7235 7235 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…-> avg) but also change in the accessor itself so that endStep and stepRange are computed correctly for post-mtg2 data and the old behaviour is preserved for pre-mtg2 data. Added a test also to make clear the intended behaviour. Passes all ctests and regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Setting typeOfTimeIncrement=1 erroneously set "stepType=avgd" (even when the period is e.g. 6h) and removes the computing of endStep and stepRange which erroneously become zero.
avgd has the undesirable behaviour of removing the endStep and stepRange, which is incorrect.
We contain this undesirable behaviour to pre-mtg2 data only to keep backwards compatibility but have post-mtg2 interpreted correctly.
This passes all ctests and regression tests.
Contributor Declaration
By opening this pull request, I affirm the following: