Skip to content

ECC-1734: GRIB2: typeOfTimeIncrement=1 removes endStep and stepRange#447

Open
mjg41 wants to merge 3 commits intodevelopfrom
bugfix/ECC-1734-fix-via-mtg2switch
Open

ECC-1734: GRIB2: typeOfTimeIncrement=1 removes endStep and stepRange#447
mjg41 wants to merge 3 commits intodevelopfrom
bugfix/ECC-1734-fix-via-mtg2switch

Conversation

@mjg41
Copy link
Copy Markdown
Collaborator

@mjg41 mjg41 commented Mar 20, 2026

Description

Setting typeOfTimeIncrement=1 erroneously set "stepType=avgd" (even when the period is e.g. 6h) and removes the computing of endStep and stepRange which erroneously become zero.

avgd has the undesirable behaviour of removing the endStep and stepRange, which is incorrect.
We contain this undesirable behaviour to pre-mtg2 data only to keep backwards compatibility but have post-mtg2 interpreted correctly.

This passes all ctests and regression tests.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

mjg41 added 2 commits March 20, 2026 11:32
…and stepRange, which is incorrect. We contain this undesirable behaviour to pre-mtg2 data only to keep backwards compatibility but have post-mtg2 interpreted correctly.

Passes all ctests and regression tests.
@mjg41 mjg41 requested review from joobog and shahramn March 20, 2026 15:06
@mjg41 mjg41 self-assigned this Mar 20, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (93b19e5) to head (3627369).
⚠️ Report is 9 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #447   +/-   ##
========================================
  Coverage    88.53%   88.53%           
========================================
  Files          849      849           
  Lines        63097    63101    +4     
  Branches     11236    11238    +2     
========================================
+ Hits         55862    55866    +4     
  Misses        7235     7235           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…-> avg) but also change in the accessor itself so that endStep and stepRange are computed correctly for post-mtg2 data and the old behaviour is preserved for pre-mtg2 data.

Added a test also to make clear the intended behaviour.
Passes all ctests and regression tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants