MARS-007 Document timespan behaviour, especially timespan=none#54
Merged
simondsmart merged 3 commits intomainfrom Apr 1, 2026
Merged
MARS-007 Document timespan behaviour, especially timespan=none#54simondsmart merged 3 commits intomainfrom
simondsmart merged 3 commits intomainfrom
Conversation
simondsmart
commented
Mar 24, 2026
| - On archive, this uses the value provided if supplied. This must match the `mars` namespace, and so will be absent for pre-MTG2 data, and present for post-. | ||
| - On retrieve, both `timespan=none` and `timespan` absent match against either `timespan=none` or `timespan` absent in the fdb index. | ||
| - This could be proposed as a standard behaviour going forward. | ||
| - We pre-analyse data in the MARS client, prior to submitting an archive request using explicit eccodes calls to determine if we are pre/post MTG2 |
Contributor
Author
There was a problem hiding this comment.
This doesn't match what is written in the decision. We state below that archive/wipe must match the contents of the MARS namespace. That is probably correct. As written is very much optional (and probably not ideal)
simondsmart
commented
Mar 24, 2026
| - We introduce a new semantic for the MARS language. | ||
| * `keyword=none` is strictly equivalent to `keyword` unspecified | ||
| * This behaviour can be extended to other contexts in the future, where appropriate, but should be consistent in all cases. | ||
| New development required |
Contributor
Author
There was a problem hiding this comment.
Newlines here being lost in formatting. Need to add more newlines...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributor Declaration
By opening this pull request, I affirm the following: