Skip to content

ADR for model error fourier coefficients#49

Merged
simondsmart merged 4 commits into
ecmwf:mainfrom
rdosinski:feature/modelErrors
May 20, 2026
Merged

ADR for model error fourier coefficients#49
simondsmart merged 4 commits into
ecmwf:mainfrom
rdosinski:feature/modelErrors

Conversation

@rdosinski
Copy link
Copy Markdown
Contributor

Description

This PR contains the ADR document for the additional coeffIndex mars key for the model error fourier coefficients.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@rdosinski rdosinski marked this pull request as ready for review May 19, 2026 15:14
# MARS Language Decision Record 003: Model Error Coefficients Index

## Status
[**Proposed** | <s>Accepted</s> | <s>Deprecated</s> | <s>Superseded by [ADR-XXX]</s>]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is accepted


## Context

Initial request from RD:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a direct quote, it should be recorded/formatted as a quote. Ideally we would just rephrase.

We are developing a new formulation where we would need to archive a set of 3D-fields, instead of a single 3D-fields per physical variable. I think the best way to implement this would be to have a new GRIB variable in the template (i.e. a metadata that contains an integer). This should be then linked to a new MARS key, similar to what is done with the "member" key.
Let me know what you think, happy to discuss this further and give more details/motivations if needed.

Assessment by Data Governance
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it is meant to be a heading. But in Markdown it just gets rendered as:

Assessment by Data Governance Essentially...


### Options Considered

Option 1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, not a heading.

@simondsmart simondsmart merged commit d7a3291 into ecmwf:main May 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants