[1050] Upgrade to torch 2.9.1#2310
Open
florianscheidl wants to merge 13 commits into
Open
Conversation
…dl/WeatherGenerator into flo-upgrade-torch-2.9-cu129
This reverts commit 2334509.
…dl/WeatherGenerator into flo-upgrade-torch-2.9-cu129
Contributor
Author
|
@clessig, I think we're ready to merge this early next week. I've tested it on Jupiter, Santis, and Leonardo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We updated to torch 2.9.1 for GPU systems (at cuda 12.6, as previously).
Moreover, we checked that Juwels and HPC2020 support the newer Nvidia GPU drivers (in fact, they would all support CUDA 13.1). Leonardo only supports up to CUDA 12.6.
From the training runs, we see no errors, nor performance degradation from the version bump.
Note: We are consciously not upgrading to the most recent torch/cuda versions our hardware supports because the current most recent flash attention version only supports up to torch 2.9 and cuda 12.*, i.e., the version we choose here. We are investigating flash-attn-4 (see #2181), but as this is still in progress, we do this step-wise upgrade.
Issue Number
Closes #1050.
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60