Add support for TaskGroup.id and isDefault.

[tsmaeder]

What it does

Adds support for id and isDefault and includes a small drive-by fix in the Task implementation where the taskRunOptions object was not properly initialized.

Fixes eclipse-theia#11519

Contributed on behalf of ST Microelectronics

How to test

1. Install the attached vscode extension. It is built from https://github.com/tsmaeder/castletest
2. Open a workspace that generates some tasks. I use the source of Theia
3. Configure some tasks, playing with the "id" and "default" fields
4. Inspect the task by invoking "Dump task info to console" from the command palette and make sure the right values are shown for "isDefault" and "id".

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[tsmaeder]

castletest-0.0.1.zip

[sgraband]

Thank you for the changes! Looks good to me. Just one minor nitpick/question:

Why do we have two terms for the same field (kind and id)? Is this to achieve compatability with vscode tasks or could we align this?

[tsmaeder]

Why do we have two terms for the same field (kind and id)?

I'm glad you asked ;-) Because tasks are a mess: their typing is a mix of the schema of the tasks.json file, our internal structures and what the VS Code API wants. So task kind and task id are NOT really the same thing: they might be the id of a TaskGroup object from the VSCode API or they might be a string that is written in a tasks.json (where only "build" and "test" are allowed, by the way). Calling it id would just paper over the lack of clarity there. Different things should be name differently!

[sgraband]

Suggested change

	export type TaskGroupKind = 'build' | 'test' | 'rebuild' | 'clean'
	export type TaskGroupKind = 'build' | 'test' | 'rebuild' | 'clean';

Seems like the linter requires a semicolon here.

[sgraband]

Thanks for the clarification. The linter and the tests are complaining, though. Could you check that?

[tsmaeder]

The tests complain that that "Values have same structure but are not reference-equal". I suspect it's because the TaskGroup constants use the unwrapped TaskGroup constructor, whereas type-converter.ts uses the @Es5Compat-annotated version of the constructor. I'm not sure whether that is a real problem or not, you're probably a better judge of it (seeing that you did eclipse-theia#9436). I can fix the test, though 🤷

[sgraband]

Great thank you! Using the es5-wrapped constructor should not be an issue. LGTM 👍