Add support for theia.DebugSession.parentSession#55
Add support for theia.DebugSession.parentSession#55tsmaeder wants to merge 1 commit intoeclipsesource:masterfrom
Conversation
Adds support for the parentSession property in theia.d.ts. Includes some minor changes to make sure we're not sending theia.DebugSession object over the wire, but only session ids. Contributed on behalf of ST Microelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
|
@planger how about a review? |
@tsmaeder I cannot see a pre-built copy of the extension on this PR or the issue. Am i not seeing something? 👀 |
sgraband
left a comment
There was a problem hiding this comment.
Thank you!
Apart from the missing pre built extension i mentioned above this looks and works great!
Promises, promises! Here you go: |
sgraband
left a comment
There was a problem hiding this comment.
Great! Thank you! I already tested it, as i still had the extension from my earlier review, but the theia main repo reviewer will probably not have it 😉
LGTM 👍
What it does
Add suppport vor DebugSession.parentSession. Fixes eclipse-theia#11512
Adds support for the parentSession property in theia.d.ts. Includes some minor changes to make sure we're not sending theia.DebugSession object over the wire, but only session ids.
Contributed on behalf of ST Microelectronics
How to test
Review checklist
Reminder for reviewers