style:added overflow:scroll to textfields#293
Open
Pavan-Rajesh wants to merge 1 commit intoeclipsesource:masterfrom
Open
style:added overflow:scroll to textfields#293Pavan-Rajesh wants to merge 1 commit intoeclipsesource:masterfrom
Pavan-Rajesh wants to merge 1 commit intoeclipsesource:masterfrom
Conversation
sdirix
requested changes
Apr 8, 2024
Member
sdirix
left a comment
There was a problem hiding this comment.
Thanks for the PR! Can you minimize the PR to the minimum, i.e. only adding the overflow styling instead of doing all the additional formatting changes?
sdirix
requested changes
Apr 10, 2024
Member
sdirix
left a comment
There was a problem hiding this comment.
While the proposed change fixes the issue, we now have scroll bars for every demo example which is visually not appealing. We should find an alternative solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added
overflow:scrollto the divnew One after modifying
