Skip to content

feat: Add configurable split-package detection via detect_split_packages setting #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
runchen0919 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add configurable split-package detection via detect_split_packages setting #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions ....core/src/com/salesforce/bazel/eclipse/core/model/discovery/BaseProvisioningStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ public abstract class BaseProvisioningStrategy implements TargetProvisioningStra
private static final String JRE_SYSTEM_LIBRARY_RUNTIME = "current_java_runtime";
private static final String JRE_SYSTEM_LIBRARY_EE = "execution_environment";
private static final String CLASSPATH_DEPTH = "classpath_depth";
private static final String DETECT_SPLIT_PACKAGES = "detect_split_packages";

private static final String JAVAC_OPT_ADD_OPENS = "--add-opens";
private static final String JAVAC_OPT_ADD_EXPORTS = "--add-exports";
Expand Down Expand Up @@ -1390,7 +1391,13 @@ protected String getProjectNameFriendlyPackagePath(BazelPackage bazelPackage) th
* Calls and returns {@link JavaProjectInfo#analyzeProjectRecommendations(boolean, IProgressMonitor)} with
* recommended defaults.
* <p>
* Subclasses may override to customize defaults
* Subclasses may override to customize defaults.
* </p>
* <p>
* The <code>detect_split_packages</code> setting in <code>target_provisioning_settings</code> can be used to
* control whether split-package detection is enabled. When set to <code>false</code>, folders containing more
* Java files than declared for a particular target will not be reported as a problem. The default is
* <code>true</code>.
* </p>
*
* @param javaInfo
Expand All @@ -1403,7 +1410,12 @@ protected String getProjectNameFriendlyPackagePath(BazelPackage bazelPackage) th
*/
protected IStatus getProjectRecommendations(JavaProjectInfo javaInfo, IProgressMonitor monitor)
throws CoreException {
return javaInfo.analyzeProjectRecommendations(true, monitor);
var detectSplitPackages = Boolean.parseBoolean(
getFileSystemMapper().getBazelWorkspace()
.getBazelProjectView()
.targetProvisioningSettings()
.getOrDefault(DETECT_SPLIT_PACKAGES, "true"));
return javaInfo.analyzeProjectRecommendations(detectSplitPackages, monitor);
}

protected String getTargetProvisioningSetting(BazelElement<?, ?> bazelElement, String key, String defaultValue)
Expand Down
1 change: 1 addition & 0 deletions docs/common/projectviews.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ The syntax of each entry is `key=value`, where `key` and `value` are expected st
* `classpath_depth` A integer indicating the depth of source targets runtime dependencies pulled in to the project model during sync (default is `0`, which pulls in all transitive dependencies in the graph).
* Providing a value greater then 0 will filter transitive dependencies and provide a partial classpath to the project model.
* Note: While all required compile-time dependencies are added regardless, there may be edge cases with the Eclipse compiler which may result in compile errors.
* `detect_split_packages` (possible values: `true` (default) and `false`; when set to `false`, the IDE will not report warnings for folders containing more Java files than declared in a particular target's `srcs`. This is useful for monorepo setups where multiple Bazel targets share the same source directory hierarchy. Note: this setting has no effect on the `project-per-package` strategy, which never performs split-package detection.)

### `target_discovery_settings`

Expand Down
Loading