Skip to content

Fix Infinite Recursion Issue in BazelClasspathContainerRuntimeResolver #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
runchen0919 wants to merge 1 commit into from
Closed

Fix Infinite Recursion Issue in BazelClasspathContainerRuntimeResolver #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ...c/com/salesforce/bazel/eclipse/core/classpath/BazelClasspathContainerRuntimeResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,17 @@ private void populateWithSavedContainer(IJavaProject project,
var sourceProject = workspaceRoot.getProject(e.getPath().segment(0));
if (processedProjects.add(sourceProject)) {
// only resolve and add the projects if it was never attempted before
populateWithResolvedProject(resolvedClasspath, sourceProject);
// For Bazel projects, check if they have a saved container and use it directly
// to avoid expensive computeUnresolvedRuntimeClasspath calls
var sourceJavaProject = JavaCore.create(sourceProject);
var sourceBazelContainer = getClasspathManager().getSavedContainer(sourceProject);
if (sourceBazelContainer != null) {
// Bazel project: recursively populate using its saved container
populateWithSavedContainer(sourceJavaProject, resolvedClasspath, processedProjects);
} else {
// Non-Bazel project: fall back to standard Eclipse resolution
populateWithResolvedProject(resolvedClasspath, sourceProject);
}
} else if (LOG.isDebugEnabled()) {
LOG.debug(
"Skipping recursive resolution attempt for project '{}' in thread '{}' ({})",
Expand Down
Loading