Fix zenoh pico connectivity guard for closures#771
Merged
milyin merged 2 commits intoeclipse-zenoh:mainfrom Apr 10, 2026
Merged
Fix zenoh pico connectivity guard for closures#771milyin merged 2 commits intoeclipse-zenoh:mainfrom
milyin merged 2 commits intoeclipse-zenoh:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens the preprocessor guards around the (unstable) connectivity-related C++ closure callbacks and public API includes so they are only enabled when the underlying C backend actually provides connectivity support (zenoh-c always, zenoh-pico only when Z_FEATURE_CONNECTIVITY == 1).
Changes:
- Gate inclusion of connectivity-related API headers in
closures_concrete.hxxonZ_FEATURE_CONNECTIVITY == 1(for zenoh-pico) orZENOHCXX_ZENOHC(for zenoh-c). - Gate inclusion of connectivity-related headers in the top-level
api.hxxaggregator with the same condition.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| include/zenoh/detail/closures_concrete.hxx | Prevents compiling/linking connectivity closure callbacks when connectivity is not available in the backend. |
| include/zenoh/api.hxx | Prevents exposing connectivity API headers via the umbrella header when the backend lacks connectivity support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
milyin
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix zenoh pico connectivity guard for closures to check for Z_FEATURE_CONNECTIVITY==1