[GEF] Harmonize Source Feedback handling in EditPart with upstream class#1425
Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom Apr 2, 2026
Merged
Conversation
ptziegler
force-pushed
the
gef-source-feedback
branch
from
3e59ee9 to
d241407
Compare
This is a continuation of 1ea6950. The `eraseSourceFeedback(Request)` and `showSourceFeedback(Request)` methods inside an `EditPart` should not check whether its `EditPolicy` understands the request; This should instead be done by the edit policies themselves.
ptziegler
force-pushed
the
gef-source-feedback
branch
from
d241407 to
23a57ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of 1ea6950. The
eraseSourceFeedback(Request)andshowSourceFeedback(Request)methods inside anEditPartshould not check whether itsEditPolicyunderstands the request; This should instead be done by the edit policies themselves.