sigint: Handle SIGINT cleanups cleanly #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Addresses #245. |
boaks
reviewed
Jan 17, 2025
tests/dtls-client.c
Outdated
| static unsigned int force_extended_master_secret = 0; | ||
| static unsigned int force_renegotiation_info = 0; | ||
|
|
||
| static int quit = 0; |
Contributor
There was a problem hiding this comment.
C is too long ago for me ;-).
Doesn't this require a volatile?
Contributor
Author
There was a problem hiding this comment.
Good question. If the while (!quit) loop did not call other functions, volatile would certainly be needed. Here, the compiler is unlikely to optimize it out as it is a global, but I guess that it is possible.
I will update the PR accordingly.
Signed-off-by: Jon Shallow <supjps-libcoap@jpshallow.com>
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.