-
Notifications
You must be signed in to change notification settings - Fork 901
Improve RV64/GNU port robustness, portability, and CSR handling #496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
started writing the readme risc-v64/gnu/readme_threadx.txt for rv64/gnu, please feel free to comment what to add/remove. |
- removed tx_port.h dependency from .S files - replaced tx_timer_interrupt.c with tx_timer_interrupt.S - made some cleanups, formatting to better readability - removed macros (LOAD/STORE/REGBYTES) changed register nomenclature to use RISC-V ABI names (ra, sp, t0, etc.) - added readme_threadx.txt Signed-off-by: Akif Ejaz <akif.ejaz@10xengineers.ai>
9c664e4 to
6c25eff
Compare
Signed-off-by: Akif Ejaz <akif.ejaz@10xengineers.ai>
|
Hi @billlamiework, as per your suggestions here #490 (comment), I've updated the RV64/GNU port, It should include following changes. Please review the changes when you get time.
Once we have risc-v64/gnu port fixed/formatted correctly, I'll do the same for risc-v32/gnu. |
|
Definitely looking good... my only comments are:
|
- removed the trailing whitespaces Signed-off-by: Akif Ejaz <akif.ejaz@10xengineers.ai>
Thanks again for review, I've adjusted the comments and also the macro in tx_port.h as you suggested. cc @fdesbiens this is ready from myside. |
|
Well done, @akifejaz! Merging this PR now. It will ship with our 202601 release in March. |
improve port robustness, portability, and CSR handling
changed register nomenclature to use RISC-V ABI
names (ra, sp, t0, etc.)