Skip to content

Opcua binding refactor #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erossignon wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Opcua binding refactor #1451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
100a9fd
chore(binding-opcua): remove redundant findBasicDataType
erossignon Oct 27, 2025
21ce56a
feat(binding-opcua): fix connection mutualisation bug
erossignon Oct 27, 2025
1b26f48
chore(binding-opcua): refactor codec into multiple files
erossignon Oct 27, 2025
e11d668
Update packages/binding-opcua/src/codecs/opcua-binary-codec.ts
erossignon Nov 3, 2025
7648816
Update packages/binding-opcua/src/codecs/opcua-data-schemas.ts
erossignon Nov 3, 2025
5a38d23
Update packages/binding-opcua/src/codecs/opcua-json-codec.ts
erossignon Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
279 changes: 3 additions & 276 deletions packages/binding-opcua/src/codec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,279 +12,6 @@
*
* SPDX-License-Identifier: EPL-2.0 OR W3C-20150513
********************************************************************************/

import { ContentCodec, DataSchema, createLoggers } from "@node-wot/core";
import { DataValue } from "node-opcua-data-value";
import { DataType, Variant } from "node-opcua-variant";
import Ajv from "ajv";
import addFormats from "ajv-formats";

// see https://www.w3.org/Protocols/rfc1341/4_Content-Type.html
import {
opcuaJsonEncodeDataValue,
opcuaJsonDecodeDataValue,
opcuaJsonDecodeVariant,
DataValueJSON,
opcuaJsonEncodeVariant,
} from "node-opcua-json";
import { BinaryStream } from "node-opcua-binary-stream";
import { DataSchemaValue } from "wot-typescript-definitions";

const { debug } = createLoggers("binding-opcua", "codec");

// Strict mode has a lot of other checks and it prevents runtime unexpected problems
// TODO: in the future we should use the strict mode
const ajv = new Ajv({ strict: false });
addFormats(ajv);
/**
* this schema, describe the node-opcua JSON format for a DataValue object
*
* const pojo = (new DataValue({})).toString();
*
*/
export const schemaDataValue = {
type: ["object"], // "number", "integer", "string", "boolean", "array", "null"],
properties: {
serverPicoseconds: { type: "integer" },
sourcePicoseconds: { type: "integer" },
serverTimestamp: { type: "string", /* format: "date", */ nullable: true },
sourceTimestamp: { type: "string", /* format: "date", */ nullable: true },
statusCode: {
type: ["object"],
properties: {
value: {
type: "number",
},
},
},
value: {
type: ["object"],
properties: {
dataType: {
type: ["string", "integer"],
},
arrayType: {
type: ["string"],
},
value: {
type: ["number", "integer", "string", "boolean", "array", "null", "object"],
},
dimension: {
type: ["array"],
items: { type: "integer" },
},
additionalProperties: false,
},
},
},
additionalProperties: true,
};

export const schemaVariantJSONNull = {
type: "null",
nullable: true,
};

export const schemaVariantJSON = {
type: "object",
properties: {
Type: {
type: ["number"],
},
Body: {
type: ["number", "integer", "string", "boolean", "array", "null", "object"],
nullable: true,
},
Dimensions: {
type: ["array"],
items: { type: "integer" },
},
},
additionalProperties: false,
required: ["Type", "Body"],
};

export const schemaDataValueJSON1 = {
type: ["object"], // "number", "integer", "string", "boolean", "array", "null"],
properties: {
ServerPicoseconds: { type: "integer" },
SourcePicoseconds: { type: "integer" },
ServerTimestamp: {
type: "string" /*, format: "date" */,
},
SourceTimestamp: {
type: "string" /*, format: "date" */,
},
StatusCode: {
type: "integer",
minimum: 0,
},

Value: schemaVariantJSON,
Value1: { type: "number", nullable: true },

Value2: {
oneOf: [schemaVariantJSON, schemaVariantJSONNull],
},
},

additionalProperties: false,
required: ["Value"],
};
export const schemaDataValueJSON2 = {
properties: {
Value: { type: "null" },
},
};
export const schemaDataValueJSON = {
oneOf: [schemaDataValueJSON2, schemaDataValueJSON1],
};
export const schemaDataValueJSONValidate = ajv.compile(schemaDataValueJSON);
export const schemaDataValueValidate = ajv.compile(schemaDataValue);

export function formatForNodeWoT(dataValue: DataValueJSON): DataValueJSON {
// remove unwanted/unneeded properties
delete dataValue.SourcePicoseconds;
delete dataValue.ServerPicoseconds;
delete dataValue.ServerTimestamp;
return dataValue;
}

// application/json => is equivalent to application/opcua+json;type=Value

export class OpcuaJSONCodec implements ContentCodec {
getMediaType(): string {
return "application/opcua+json";
}

bytesToValue(bytes: Buffer, schema: DataSchema, parameters?: { [key: string]: string }): DataSchemaValue {
const type = parameters?.type ?? "DataValue";
let parsed = JSON.parse(bytes.toString());

const wantDataValue = parameters?.to === "DataValue" || false;

switch (type) {
case "DataValue": {
const isValid = schemaDataValueJSONValidate(parsed);
if (!isValid) {
debug(`bytesToValue: parsed = ${parsed}`);
debug(`bytesToValue: ${schemaDataValueJSONValidate.errors}`);
throw new Error("Invalid JSON dataValue : " + JSON.stringify(parsed, null, " "));
}
if (wantDataValue) {
return opcuaJsonDecodeDataValue(parsed);
}
return formatForNodeWoT(opcuaJsonEncodeDataValue(opcuaJsonDecodeDataValue(parsed), true));
// return parsed;
}
case "Variant": {
if (wantDataValue) {
const dataValue = new DataValue({ value: opcuaJsonDecodeVariant(parsed) });
return dataValue;
}
const v = opcuaJsonEncodeVariant(opcuaJsonDecodeVariant(parsed), true);
debug(`${v}`);
return v;
}
case "Value": {
if (wantDataValue) {
if (!parameters || !parameters.dataType) {
throw new Error("[OpcuaJSONCodec|bytesToValue]: unknown dataType for Value encoding" + type);
}
if (parameters.dataType === DataType[DataType.DateTime]) {
parsed = new Date(parsed);
}
const value = {
dataType: DataType[parameters.dataType as keyof typeof DataType],
value: parsed,
};
return new DataValue({ value });
} else {
if (parameters?.dataType === DataType[DataType.DateTime]) {
parsed = new Date(parsed);
}
return parsed;
}
}
default:
throw new Error("[OpcuaJSONCodec|bytesToValue]: Invalid type " + type);
}
}

valueToBytes(value: unknown, _schema: DataSchema, parameters?: { [key: string]: string }): Buffer {
const type = parameters?.type ?? "DataValue";
switch (type) {
case "DataValue": {
let dataValueJSON: DataValueJSON;
if (value instanceof DataValue) {
dataValueJSON = opcuaJsonEncodeDataValue(value, true);
} else if (value instanceof Variant) {
dataValueJSON = opcuaJsonEncodeDataValue(new DataValue({ value }), true);
} else if (typeof value === "string") {
dataValueJSON = JSON.parse(value) as DataValueJSON;
} else {
dataValueJSON = opcuaJsonEncodeDataValue(opcuaJsonDecodeDataValue(value as DataValueJSON), true);
}
dataValueJSON = formatForNodeWoT(dataValueJSON);
return Buffer.from(JSON.stringify(dataValueJSON), "ascii");
}
case "Variant": {
if (value instanceof DataValue) {
value = opcuaJsonEncodeVariant(value.value, true);
} else if (value instanceof Variant) {
value = opcuaJsonEncodeVariant(value, true);
} else if (typeof value === "string") {
value = JSON.parse(value);
}
return Buffer.from(JSON.stringify(value), "ascii");
}
case "Value": {
if (value === undefined) {
return Buffer.alloc(0);
}
if (value instanceof DataValue) {
value = opcuaJsonEncodeVariant(value.value, false);
} else if (value instanceof Variant) {
value = opcuaJsonEncodeVariant(value, false);
}
return Buffer.from(JSON.stringify(value), "ascii");
}
default:
throw new Error("[OpcuaJSONCodec|valueToBytes]: Invalid type : " + type);
}
}
}
export const theOpcuaJSONCodec = new OpcuaJSONCodec();

export class OpcuaBinaryCodec implements ContentCodec {
getMediaType(): string {
return "application/opcua+octet-stream"; // see Ege
}

bytesToValue(bytes: Buffer, schema: DataSchema, parameters?: { [key: string]: string }): DataValueJSON {
const binaryStream = new BinaryStream(bytes);
const dataValue = new DataValue();
dataValue.decode(binaryStream);
return opcuaJsonEncodeDataValue(dataValue, true);
}

valueToBytes(
dataValue: DataValueJSON | DataValue,
schema: DataSchema,
parameters?: { [key: string]: string }
): Buffer {
dataValue = dataValue instanceof DataValue ? dataValue : opcuaJsonDecodeDataValue(dataValue);

// remove unwanted properties
dataValue.serverPicoseconds = 0;
dataValue.sourcePicoseconds = 0;
dataValue.serverTimestamp = null;

const size = dataValue.binaryStoreSize();
const stream = new BinaryStream(size);
dataValue.encode(stream);
const body = stream.buffer;
return body;
}
}
export const theOpcuaBinaryCodec = new OpcuaBinaryCodec();
export * from "./codecs/opcua-binary-codec";
export * from "./codecs/opcua-json-codec";
export * from "./codecs/opcua-data-schemas";
53 changes: 53 additions & 0 deletions packages/binding-opcua/src/codecs/opcua-binary-codec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
/********************************************************************************
* Copyright (c) 2025 Contributors to the Eclipse Foundation
*
* See the NOTICE file(s) distributed with this work for additional
* information regarding copyright ownership.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v. 2.0 which is available at
* http://www.eclipse.org/legal/epl-2.0, or the W3C Software Notice and
* Document License (2015-05-13) which is available at
* https://www.w3.org/Consortium/Legal/2015/copyright-software-and-document.
*
* SPDX-License-Identifier: EPL-2.0 OR W3C-20150513
********************************************************************************/

import { ContentCodec, DataSchema } from "@node-wot/core";
import { BinaryStream } from "node-opcua-binary-stream";
import { DataValue } from "node-opcua-data-value";

import { opcuaJsonEncodeDataValue, opcuaJsonDecodeDataValue, DataValueJSON } from "node-opcua-json";

export class OpcuaBinaryCodec implements ContentCodec {
getMediaType(): string {
return "application/opcua+octet-stream"; // see Ege
Copy link
Member

@danielpeintner danielpeintner Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return "application/opcua+octet-stream"; // see Ege
return "application/opcua+octet-stream";

}

bytesToValue(bytes: Buffer, schema: DataSchema, parameters?: { [key: string]: string }): DataValueJSON {
const binaryStream = new BinaryStream(bytes);
const dataValue = new DataValue();
dataValue.decode(binaryStream);
return opcuaJsonEncodeDataValue(dataValue, true);
}

valueToBytes(
dataValue: DataValueJSON | DataValue,
schema: DataSchema,
parameters?: { [key: string]: string }
): Buffer {
dataValue = dataValue instanceof DataValue ? dataValue : opcuaJsonDecodeDataValue(dataValue);

// remove unwanted properties
dataValue.serverPicoseconds = 0;
dataValue.sourcePicoseconds = 0;
dataValue.serverTimestamp = null;

const size = dataValue.binaryStoreSize();
const stream = new BinaryStream(size);
dataValue.encode(stream);
const body = stream.buffer;
return body;
}
}
export const theOpcuaBinaryCodec = new OpcuaBinaryCodec();
Loading